Skip to content

Add more documentation for SystemChannels.keyboard getKeyboardState #133663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Sep 1, 2023
Merged

Add more documentation for SystemChannels.keyboard getKeyboardState #133663

auto-submit merged 1 commit into from
Sep 1, 2023

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Aug 30, 2023

Description

This PR adds some documentation to SystemChannels.keyboard getKeyboardState.
This method was added in #122885.

Related Issue

Fixes #132938.

Tests

Documentation only.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 30, 2023
@bleroux bleroux requested a review from justinmc August 30, 2023 12:55
@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ a: text input Entering text in a text field or keyboard related problems labels Aug 30, 2023
justinmc
justinmc approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gintominto5329 Does this make sense to you?

packages/flutter/lib/src/services/system_channels.dart Outdated
Copy link
Contributor

@justinmc justinmc Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add an empty line /// above this.

@bleroux bleroux force-pushed the getKeyboardState_documentation branch from 8ac1815 to 16b01ce Compare September 1, 2023 07:43
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit auto-submit bot merged commit e326199 into flutter:master Sep 1, 2023
@bleroux bleroux deleted the getKeyboardState_documentation branch September 1, 2023 12:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
76c1af5 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
d373fb2 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
4cb606c 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
d30465a 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
ae44cbf 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
df881a0 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
400a7e6 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
a6038a9 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
20314e0 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
ea1aa99 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
02a9ee5 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
72169d1 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
fa71c00 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
c290c70 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
eafd941 
…dState (flutter/flutter#133663)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
37a6059 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
d48a3f1 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
8783189 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
0b32253 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
b8815a2 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
19e2010 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
2392a23 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
c56e679 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
3220d84 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
e0146db 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
de29541 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
3088500 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
74ffd07 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
05e9532 
…dState (flutter/flutter#133663)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
e326199 Add more documentation for SystemChannels.keyboard getKeyboar…
4c1a518 
…dState (flutter/flutter#133663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[missing Docs] in-complete docs, on why and when is services:SystemChannels.keyboard::getKeyboardState needed

3 participants

@bleroux @justinmc @Piinks