Skip to content

Expose barrierDismissible in PageRoute constructor #133659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 30, 2023
Merged

Expose barrierDismissible in PageRoute constructor #133659

auto-submit merged 1 commit into from
Aug 30, 2023

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Aug 30, 2023

Description

This PR exposes barrierDismissible in PageRoute, MaterialPageRoute and CupertinoPageRoute constructors.
Setting this property to true will enable the escape key binding.

Related Issue

Fixes #132138.

Tests

Adds one test.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository f: routes Navigator, Router, and related APIs. labels Aug 30, 2023
@bleroux bleroux requested a review from gspencergoog August 30, 2023 12:57
gspencergoog
gspencergoog approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2023
@auto-submit auto-submit bot merged commit b231052 into flutter:master Aug 30, 2023
@bleroux bleroux deleted the material_page_route_escape_key branch August 30, 2023 19:02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
b231052 Expose barrierDismissible in PageRoute constructor (flutter/f…
c1bb47a 
…lutter#133659)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
Roll Flutter from 1fe2495 to c175cf8 (30 revisions) (#4825)
17406a3 
flutter/flutter@1fe2495...c175cf8

2023-08-31 [email protected] Ignore macOS Cocoapods linting failure on DT_TOOLCHAIN_DIR error (flutter/flutter#133588)
2023-08-31 [email protected] `InputDecorationTheme.isCollapsed` doesn't work if `InputDecoration.isCollapsed` is not provided. (flutter/flutter#133189)
2023-08-31 [email protected] Roll Flutter Engine from 5156c03344eb to 772d5e996af8 (1 revision) (flutter/flutter#133752)
2023-08-31 [email protected] Roll Flutter Engine from 1917fa95ea55 to 5156c03344eb (2 revisions) (flutter/flutter#133745)
2023-08-31 [email protected] Roll Flutter Engine from 1f1071d3f5ba to 1917fa95ea55 (2 revisions) (flutter/flutter#133739)
2023-08-31 [email protected] Roll Flutter Engine from e88b21b6d4e8 to 1f1071d3f5ba (1 revision) (flutter/flutter#133737)
2023-08-31 [email protected] Roll Flutter Engine from 0559a733c888 to e88b21b6d4e8 (1 revision) (flutter/flutter#133735)
2023-08-31 [email protected] Roll Flutter Engine from 3b75e3de7ef3 to 0559a733c888 (1 revision) (flutter/flutter#133734)
2023-08-31 [email protected] [framework] use ImageFilter for stretch overscroll. (flutter/flutter#133613)
2023-08-31 [email protected] Roll Flutter Engine from 73e86369614d to 3b75e3de7ef3 (2 revisions) (flutter/flutter#133724)
2023-08-31 [email protected] Roll Flutter Engine from 8f1b77b1ac69 to 73e86369614d (1 revision) (flutter/flutter#133720)
2023-08-31 [email protected] Roll Flutter Engine from d37cef84d40d to 8f1b77b1ac69 (1 revision) (flutter/flutter#133714)
2023-08-31 [email protected] Mark leak in _DraggableScrollableSheetState. (flutter/flutter#133693)
2023-08-30 [email protected] Mark routing test as leaking. (flutter/flutter#133697)
2023-08-30 [email protected] Roll Flutter Engine from b63eee2e31cc to d37cef84d40d (3 revisions) (flutter/flutter#133706)
2023-08-30 [email protected] _RawAutocompleteState should dispose _highlightedOptionIndex. (flutter/flutter#133700)
2023-08-30 [email protected] Forward-fix a test that will break with an engine roll. (flutter/flutter#133619)
2023-08-30 [email protected] Fix `cancelButtonStyle` & `confirmButtonStyle` properties  from `TimePickerTheme`  aren't working (flutter/flutter#132843)
2023-08-30 [email protected] Updated DropdownMenu example and added a test (flutter/flutter#133592)
2023-08-30 [email protected] Add `cancelButtonStyle` & `confirmButtonStyle` to the `DatePickerThemeData` (flutter/flutter#132847)
2023-08-30 [email protected] Roll Flutter Engine from 31d5662dcb53 to b63eee2e31cc (1 revision) (flutter/flutter#133692)
2023-08-30 [email protected] Fixing memory leak in EditableTextState (flutter/flutter#131377)
2023-08-30 [email protected] Roll Flutter Engine from 69f04bdfe952 to 31d5662dcb53 (14 revisions) (flutter/flutter#133683)
2023-08-30 [email protected] Expose barrierDismissible in PageRoute constructor (flutter/flutter#133659)
2023-08-30 [email protected] Update the infrastructure issue template (flutter/flutter#133519)
2023-08-30 [email protected] Reland "Remove ImageProvider.load, DecoderCallback and `PaintingBinding.instantiateImageCodec` (#132679) (reverted in #133482) (flutter/flutter#133605)
2023-08-30 [email protected] Roll Packages from d7d3150 to 64af59e (4 revisions) (flutter/flutter#133675)
2023-08-30 [email protected] Update & improve `TabBar.labelColor` tests (flutter/flutter#133668)
2023-08-30 [email protected] Bump gradle heap size limits in templates (flutter/flutter#133671)
2023-08-30 [email protected] Marks Windows module_test to be flaky (flutter/flutter#133640)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
b231052 Expose barrierDismissible in PageRoute constructor (flutter/f…
5609f37 
…lutter#133659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Escape keystroke doesn't work

2 participants

@bleroux @gspencergoog