Skip to content

[CP] Update vm_snapshot_analysis to 0.7.6 on stable #133657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 10, 2023
Merged

[CP] Update vm_snapshot_analysis to 0.7.6 on stable #133657

auto-submit merged 2 commits into from
Sep 10, 2023

Conversation

@sstrickl
Copy link
Contributor

@sstrickl sstrickl commented Aug 30, 2023

Partially cherry picks 3b8f6c4, in particular it only performs the update of vm_snapshot_analysis to 0.7.6.

Issues fixed:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository a: desktop Running on desktop labels Aug 30, 2023
@sstrickl sstrickl mentioned this pull request Aug 30, 2023
Closed
@sstrickl sstrickl changed the base branch from master to flutter-3.13-candidate.0 August 30, 2023 12:11
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 30, 2023

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

christopherfujino
christopherfujino reviewed Aug 30, 2023
View reviewed changes
dev/forbidden_from_release_tests/pubspec.yaml
path: 1.8.3
process: 4.2.4
vm_snapshot_analysis: 0.7.2
vm_snapshot_analysis: 0.7.6
Copy link
Contributor

@christopherfujino christopherfujino Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is bumping from 0.7.2 -> 0.7.6, I'm guessing it's picking up other changes than the fix? Can you publish a special hotfix release of vm_snapshot_analysis, like a version 0.7.2+1, that way we can minimize the diff in the Flutter SDK?

I'll be writing up a pub dependency cherrypick to Flutter SDK playbook so that hopefully in the future there will be a clear steps to do this.

Copy link
Contributor Author

@sstrickl sstrickl Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the non-dev versions from 0.7.2 to 0.7.6 were to address the null check failures in 0.7.2, so 0.7.2+1 would basically be the exact same package. I can do that if desired, but it seems a bit silly to do so.

Copy link
Contributor

@christopherfujino christopherfujino Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, ok, this sounds good to me then

christopherfujino
christopherfujino approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

christopherfujino commented Aug 31, 2023

Hmm, @CaseyHillers do you know why the ci.yaml check is failing? https://github.com/flutter/flutter/pull/133657/checks?check_run_id=16343588795 it looks to me like the branching is correct.

@CaseyHillers
Copy link
Contributor

CaseyHillers commented Aug 31, 2023

Hmm, @CaseyHillers do you know why the ci.yaml check is failing? https://github.com/flutter/flutter/pull/133657/checks?check_run_id=16343588795 it looks to me like the branching is correct.

There's some weird issue where GitHub doesn't send the right ref. I clicked rerun, which should fix the issue.

@github-actions github-actions bot added c: contributor-productivity Team-specific productivity, code health, technical debt. and removed a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository labels Sep 8, 2023
@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2023
@auto-submit auto-submit bot merged commit a625ad4 into flutter:flutter-3.13-candidate.0 Sep 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2023
@engine-flutter-autoroll
a625ad4ea [CP] Update vm_snapshot_analysis to 0.7.6 on stable (flutte…
3407652 
…r/flutter#133657)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2023
@engine-flutter-autoroll
a625ad4ea [CP] Update vm_snapshot_analysis to 0.7.6 on stable (flutte…
f4803f1 
…r/flutter#133657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sstrickl @christopherfujino @CaseyHillers @itsjustkevin