-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Fixed PaginatedDataTable not using dataRowMinHeight and dataRowMaxHeight from Theme
#133634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@MarkOSullivan94 This requires a test in the |
PaginatedDataTable not using dataRowMinHeight and dataRowMaxHeight from Theme
|
@MarkOSullivan94 |
4cd5d38 to
e884d8c
Compare
|
@TahaTesser sorry was busy with other commitments Added a test to
Also squashed the commits Let me know if there's anything else |
…ght from Theme Co-authored-by: Taha Tesser <[email protected]>
e884d8c to
0502460
Compare
Co-authored-by: Taha Tesser <[email protected]>
ea2a4e5 to
dddb35e
Compare
TahaTesser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This will need a second review from @HansMuller before we land. |
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
…dataRowMaxHeight` from Theme (flutter/flutter#133634)
PaginatedDataTablewill now make use ofdataRowMinHeightanddataRowMaxHeightfrom the ThemeList which issues are fixed by this PR. You must list at least one issue.
Resolves #133633
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.