Revert "ShortcutManager should dispatch creation in constructor." #133472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
vashworth
added
warning: land on red to fix tree breakage
revert
fluttergithubbot
approved these changes
Aug 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 28, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 28, 2023
flutter/flutter@cd3aeef...ec387a4 2023-08-28 [email protected] Revert "ShortcutManager should dispatch creation in constructor." (flutter/flutter#133472) 2023-08-28 [email protected] Roll Flutter Engine from 9ab2603db24f to 91522a188bda (2 revisions) (flutter/flutter#133462) 2023-08-28 [email protected] FocusNode and FocusManager should dispatch creation in constructor. (flutter/flutter#133352) 2023-08-28 [email protected] ShortcutManager should dispatch creation in constructor. (flutter/flutter#133356) 2023-08-28 [email protected] Fix stuck predictive back platform channel calls (flutter/flutter#133368) 2023-08-28 [email protected] added option to change color of heading row(flutter#132428) (flutter/flutter#132728) 2023-08-28 [email protected] PlatformRouteInformationProvider should dispatch creation in constructor. (flutter/flutter#133353) 2023-08-28 [email protected] Roll Flutter Engine from 4924cf453398 to 9ab2603db24f (1 revision) (flutter/flutter#133449) 2023-08-28 [email protected] Roll Flutter Engine from d89824ab018f to 4924cf453398 (1 revision) (flutter/flutter#133447) 2023-08-28 [email protected] Roll Flutter Engine from b26e2da130ab to d89824ab018f (2 revisions) (flutter/flutter#133444) 2023-08-28 [email protected] Roll Flutter Engine from 78c26aeff3ee to b26e2da130ab (2 revisions) (flutter/flutter#133432) 2023-08-28 [email protected] Roll Flutter Engine from f8a171aa173f to 78c26aeff3ee (1 revision) (flutter/flutter#133428) 2023-08-28 [email protected] Roll Flutter Engine from 0593c0455fd6 to f8a171aa173f (1 revision) (flutter/flutter#133425) 2023-08-27 [email protected] Roll Flutter Engine from fc592728a7d0 to 0593c0455fd6 (4 revisions) (flutter/flutter#133419) 2023-08-27 [email protected] Roll Flutter Engine from b4e2758d6d43 to fc592728a7d0 (1 revision) (flutter/flutter#133410) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #133356
Tree is failing on Mac and Linux customer_testing on this PR.
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20customer_testing/14646/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/14974/overview