[flutter_tools] Fix TypeError when a FileSystemException happens during flutter doctor #133373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
andrewkolos
requested changes
Aug 28, 2023
packages/flutter_tools/test/general.shard/intellij/intellij_validator_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/general.shard/intellij/intellij_validator_test.dart
Outdated
Show resolved
Hide resolved
christopherfujino
force-pushed
the
type-error-in-doctor-fix
branch
from
072c10b to
c39d602
Compare
andrewkolos
reviewed
Aug 31, 2023
| import 'package:flutter_tools/src/base/version.dart'; | ||
| import 'package:flutter_tools/src/globals.dart' as globals; | ||
| import 'package:flutter_tools/src/ios/plist_parser.dart'; | ||
| import 'package:path/path.dart' show Context; // flutter_ignore: package_path_import -- We only use Context as an interface. |
Contributor
|
oops. I didn't save the nit apparently, one sec |
christopherfujino
added
the
autosubmit
andrewkolos
reviewed
Aug 31, 2023
| expect(validators.length, 1); | ||
| final DoctorValidator validator = validators.first; | ||
| expect(validator, isA<ValidatorWithResult>()); | ||
| expect(validator.title, 'Cannot determine if IntelliJ is installed'); |
Contributor
There was a problem hiding this comment.
uber nit: Consider also testing against the validator message. This would make it impossible for the test to pass if we got a validator from some other source that happens to use the same title.
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/133373, due to - The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
christopherfujino
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 6, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2023
…ens during flutter doctor (flutter/flutter#133373)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…ens during flutter doctor (flutter/flutter#133373)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133086