Skip to content

Dispose AnimationSheetRecorder to avoid leaks #133365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 8 commits into from
Sep 5, 2023
Merged

Dispose AnimationSheetRecorder to avoid leaks #133365

auto-submit merged 8 commits into from
Sep 5, 2023

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Aug 25, 2023 •
edited
Loading

This PR adds AnimationSheetRecorder.dispose, which disposes all the images generated by the recorder, eliminating leaks.

Fixes #133071.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. labels Aug 25, 2023
@dkwingsmt dkwingsmt force-pushed the dispose-animation-sheet-recorder branch from b51daf7 to 2f07874 Compare August 26, 2023 00:22
@polina-c
Copy link
Contributor

polina-c commented Aug 26, 2023

Thanks for handling this!

@Piinks Piinks self-requested a review August 28, 2023 15:02
Piinks
Piinks approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. autosubmit Merge PR when tree becomes green via auto submit App labels Aug 28, 2023
@Piinks Piinks force-pushed the dispose-animation-sheet-recorder branch from ddd61f0 to 141685b Compare August 30, 2023 16:48
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 30, 2023

auto label is removed for flutter/flutter/133365, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2023
@Piinks Piinks force-pushed the dispose-animation-sheet-recorder branch from 141685b to fb74e8d Compare August 30, 2023 21:15
@polina-c polina-c mentioned this pull request Aug 31, 2023
Closed
@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
@polina-c polina-c added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Sep 4, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 5, 2023

auto label is removed for flutter/flutter/133365, due to - The status or check suite Mac customer_testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2023
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2023
@dkwingsmt dkwingsmt deleted the dispose-animation-sheet-recorder branch September 5, 2023 20:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
43f1ab6 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
9dcee07 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
982227d 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
e109b48 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
a9d9e49 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
b311543 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
dc38df8 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
3106f38 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
7978355 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
a4e9bf0 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
25e843f 
…r#133365)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
e8b91c7 
…r#133365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
49954ca 
…r#133365)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
7832e91 
…r#133365)
@HansMuller HansMuller mentioned this pull request Sep 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
e66ec8e Dispose AnimationSheetRecorder to avoid leaks (flutter/flutte…
1e6738d 
…r#133365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AnimationSheetBuilder does not dispose images.

3 participants

@dkwingsmt @polina-c @Piinks