Reverts "Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#133224)" #133255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
added
revert
auto-submit
bot
removed
the
revert
Contributor
|
A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id' |
zanderso
changed the title
auto-submit
bot
removed
the
revert
Contributor
|
A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id' |
Member
Author
|
@ricardoamador it looks like the revert bot is not working. This PR was created using the revert button in the GitHub UI, but the revert bot is not landing it. |
Contributor
|
Taking a look. |
Contributor
|
A reverts link could not be found or was formatted incorrectly. Format is 'Reverts owner/repo#id' |
auto-submit
bot
removed
the
revert
fluttergithubbot
approved these changes
Aug 24, 2023
auto-submit
bot
deleted the
revert-133224-flutter-engine-flutter-autoroll-fcad3196-a81a-4419-98cb-b66c4884392a-1692844767
branch
Contributor
|
@zanderso the issue was that the original description looks to have been modified or Github changed the format of the body when it opens the revert. I'll take a look to make sure it is not the later. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 24, 2023
…9 (4 revisions) (#133224)" (flutter/flutter#133255)
zanderso
added a commit
to flutter/engine
that referenced
this pull request
Aug 24, 2023
Reverts #43764 Broke the wide gamut test on framework CI flutter/flutter#133255 https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20wide_gamut_ios/3186/overview
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 24, 2023
flutter/flutter@bd836cc...deeb811 2023-08-24 [email protected] Reverts "Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#133224)" (flutter/flutter#133255) 2023-08-24 [email protected] Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (flutter/flutter#133224) 2023-08-24 [email protected] Roll Flutter Engine from 67e8b825cc91 to aa98a9d2e86f (4 revisions) (flutter/flutter#133220) 2023-08-24 [email protected] Roll Flutter Engine from 27d75f6221d2 to 67e8b825cc91 (1 revision) (flutter/flutter#133214) 2023-08-23 [email protected] Remove deprecated PlatformViewsService.synchronizeToNativeViewHierarchy (flutter/flutter#133175) 2023-08-23 [email protected] Roll Flutter Engine from 58dc868c26cb to 27d75f6221d2 (14 revisions) (flutter/flutter#133211) 2023-08-23 [email protected] Remove deprecated MaterialButtonWithIconMixin (flutter/flutter#133173) 2023-08-23 [email protected] Enable ChangeNotifier clients to dispatch event of object creation in constructor. (flutter/flutter#133060) 2023-08-23 [email protected] Enable literal_only_boolean_expressions (flutter/flutter#133186) 2023-08-23 [email protected] Add android analyzer commands for applinks (flutter/flutter#131009) 2023-08-23 [email protected] Bump memory usage in gradle for platform views (flutter/flutter#133155) 2023-08-23 [email protected] [flutter_tools] Fix legacy version file not being ensured (flutter/flutter#133097) 2023-08-23 [email protected] Remove deprecated *TestValues from TestWindow (flutter/flutter#131098) 2023-08-23 [email protected] Roll Flutter Engine from ac352ba95f43 to 58dc868c26cb (2 revisions) (flutter/flutter#133165) 2023-08-23 [email protected] [web] Remove unnecessary lint ignore (flutter/flutter#133164) 2023-08-23 [email protected] Add `--experimental-wasm-type-reflection` and support newer emscripten builds. (flutter/flutter#133084) 2023-08-23 [email protected] Roll Flutter Engine from 72a06427bd37 to ac352ba95f43 (2 revisions) (flutter/flutter#133158) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Reverts flutter#43764 Broke the wide gamut test on framework CI flutter/flutter#133255 https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20wide_gamut_ios/3186/overview
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…9 (4 revisions) (#133224)" (flutter/flutter#133255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #133224
Reverting for failing wide gamut test https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20wide_gamut_ios/3186/overview