Use a fake stopwatch to remove flakiness. #133229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
Contributor
Author
|
cc @flar |
Contributor
|
you beat me to it |
Contributor
|
I'm not sure what the fake stopwatch is, so I can't really evaluate this. Since the success metric on the original test case seemed to be its timing output, it sounds like the fake stopwatch might fake the success metric itself? |
Contributor
Really what we care about here is that there are no spinner animation characters |
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/133229, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
auto label is removed for flutter/flutter/133229, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
Contributor
Author
|
I swear I've run into more flakes (mostly around the Google testing shard) trying to fix this flake than this flake itself has ever caused! 😅 |
Contributor
|
auto label is removed for flutter/flutter/133229, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
Contributor
Author
|
manually merging on red because the red is false red. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 30, 2023
flutter/flutter@6c95737...1fe2495 2023-08-30 [email protected] Update SelectableRegion test for M3 (flutter/flutter#129627) 2023-08-30 [email protected] Remove cirrus tests from the flutter framework. (flutter/flutter#133575) 2023-08-30 [email protected] Roll Flutter Engine from 749e67a947bc to 69f04bdfe952 (2 revisions) (flutter/flutter#133621) 2023-08-30 [email protected] [flutter roll] Revert "Fix `Chip.shape`'s side is not used when provided in Material 3" (flutter/flutter#133615) 2023-08-30 [email protected] Roll Flutter Engine from 9f2cf5c99b0f to 749e67a947bc (2 revisions) (flutter/flutter#133618) 2023-08-30 [email protected] Roll Flutter Engine from c5854a6b3658 to 9f2cf5c99b0f (4 revisions) (flutter/flutter#133616) 2023-08-30 [email protected] No longer include `.packages` in created `.gitignore` files (flutter/flutter#133484) 2023-08-30 [email protected] Roll Flutter Engine from db3ecf8b2739 to c5854a6b3658 (1 revision) (flutter/flutter#133610) 2023-08-29 [email protected] Roll Flutter Engine from 1feb9302050c to db3ecf8b2739 (4 revisions) (flutter/flutter#133609) 2023-08-29 [email protected] Fix one notDisposed leak and mark another. (flutter/flutter#133595) 2023-08-29 [email protected] Roll Flutter Engine from 01a1579808b5 to 1feb9302050c (1 revision) (flutter/flutter#133604) 2023-08-29 [email protected] Upgrade packages. (flutter/flutter#133593) 2023-08-29 [email protected] Cover more tests with leak tracking. (flutter/flutter#133596) 2023-08-29 [email protected] Roll Flutter Engine from 73cc3fb451fd to 01a1579808b5 (3 revisions) (flutter/flutter#133591) 2023-08-29 [email protected] Added DropdownMenuEntry.labelWidget (flutter/flutter#133491) 2023-08-29 [email protected] Use a fake stopwatch to remove flakiness. (flutter/flutter#133229) 2023-08-29 [email protected] Roll Flutter Engine from d1e6eb080f08 to 73cc3fb451fd (3 revisions) (flutter/flutter#133580) 2023-08-29 [email protected] [web] Migrate remaining web-only API usages to `dart:ui_web` (flutter/flutter#132248) 2023-08-29 [email protected] Add doxygen doc generation. (flutter/flutter#131356) 2023-08-29 [email protected] Roll Flutter Engine from 50bd80773287 to d1e6eb080f08 (2 revisions) (flutter/flutter#133570) 2023-08-29 [email protected] ShortcutManager should dispatch creation in constructor. (flutter/flutter#133487) 2023-08-29 [email protected] Add FAB Additional Color Mappings example (flutter/flutter#133453) 2023-08-29 [email protected] Roll Flutter Engine from 65438c7bb46a to 50bd80773287 (1 revision) (flutter/flutter#133565) 2023-08-29 [email protected] Roll Packages from 383bffa to d7d3150 (13 revisions) (flutter/flutter#133564) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133215