Skip to content

Users of ChangeNotifier should dispatch event of object creation in constructor. #133210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
polina-c merged 19 commits into from
Aug 24, 2023
Merged

Users of ChangeNotifier should dispatch event of object creation in constructor. #133210

polina-c merged 19 commits into from
Aug 24, 2023

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Aug 23, 2023 •
edited
Loading

Prerequisite: #133060

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: routes Navigator, Router, and related APIs. labels Aug 23, 2023
@polina-c polina-c mentioned this pull request Aug 23, 2023
Closed
@polina-c polina-c requested a review from goderbauer August 23, 2023 22:59
@polina-c polina-c marked this pull request as ready for review August 23, 2023 22:59
@polina-c
Copy link
Contributor Author

polina-c commented Aug 24, 2023

Google testing failure can be ignored, because g3 did not catch up on prerequisite PR yet:

ERROR: third_party/dart/flutter/lib/src/widgets/navigator.dart

3361: maybeDispatchObjectCreation(); Undefined method. #undefined_method

ERROR: third_party/dart/flutter/lib/src/widgets/selectable_region.dart

1560: maybeDispatchObjectCreation(); Undefined method. #undefined_method

ERROR: third_party/dart/flutter/lib/src/widgets/widget_inspector.dart

2901: maybeDispatchObjectCreation(); Undefined method. #undefined_method


google3:///[third_party/dart/flutter/lib/src/widgets/navigator.dart:3361](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter/lib/src/widgets/navigator.dart?l=3361&ws=tap-presubmit-server/94538208&snapshot=5):7: Error: The method 'maybeDispatchObjectCreation' isn't defined for the class '_History'.
 - '_History' is from 'package:flutter/src/widgets/navigator.dart' ('google3:///third_party/dart/flutter/lib/src/widgets/navigator.dart').
Try correcting the name to the name of an existing method, or defining a method named 'maybeDispatchObjectCreation'.
      maybeDispatchObjectCreation();
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
google3:///[third_party/dart/flutter/lib/src/widgets/selectable_region.dart:1560](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter/lib/src/widgets/selectable_region.dart?l=1560&ws=tap-presubmit-server/94538208&snapshot=5):7: Error: The method 'maybeDispatchObjectCreation' isn't defined for the class 'MultiSelectableSelectionContainerDelegate'.
 - 'MultiSelectableSelectionContainerDelegate' is from 'package:flutter/src/widgets/selectable_region.dart' ('google3:///third_party/dart/flutter/lib/src/widgets/selectable_region.dart').
Try correcting the name to the name of an existing method, or defining a method named 'maybeDispatchObjectCreation'.
      maybeDispatchObjectCreation();
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
google3:///[third_party/dart/flutter/lib/src/widgets/widget_inspector.dart:2901](https://cs.corp.google.com/piper///depot/google3/third_party/dart/flutter/lib/src/widgets/widget_inspector.dart?l=2901&ws=tap-presubmit-server/94538208&snapshot=5):7: Error: The method 'maybeDispatchObjectCreation' isn't defined for the class 'InspectorSelection'.
 - 'InspectorSelection' is from 'package:flutter/src/widgets/widget_inspector.dart' ('google3:///third_party/dart/flutter/lib/src/widgets/widget_inspector.dart').
Try correcting the name to the name of an existing method, or defining a method named 'maybeDispatchObjectCreation'.
      maybeDispatchObjectCreation();
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^

goderbauer
goderbauer approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit afa3789 into flutter:master Aug 24, 2023
@polina-c polina-c deleted the chn-usage branch August 24, 2023 20:42
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2023
@engine-flutter-autoroll
afa3789 Users of ChangeNotifier should dispatch event of object creat…
474e2d1 
…ion in constructor. (flutter/flutter#133210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2023
@engine-flutter-autoroll
afa3789 Users of ChangeNotifier should dispatch event of object creat…
9a54781 
…ion in constructor. (flutter/flutter#133210)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2023
@engine-flutter-autoroll
afa3789 Users of ChangeNotifier should dispatch event of object creat…
a235513 
…ion in constructor. (flutter/flutter#133210)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 25, 2023
@engine-flutter-autoroll
Roll Flutter from deeb811 to 61d9f55 (25 revisions) (#4774)
519d13a 
flutter/flutter@deeb811...61d9f55

2023-08-25 [email protected] Update flutter packages to pick up latest vm_service (flutter/flutter#133335)
2023-08-25 [email protected] Roll Flutter Engine from 00f532dcaef4 to 33fca02451ef (1 revision) (flutter/flutter#133337)
2023-08-25 [email protected] Roll Flutter Engine from cb58abd77326 to 00f532dcaef4 (3 revisions) (flutter/flutter#133333)
2023-08-25 [email protected] Fix `PopupMenuItem` with a `ListTile` doesn't use the correct style. (flutter/flutter#133141)
2023-08-25 [email protected] Fix `Chip.shape`'s side is not used when provided in Material 3 (flutter/flutter#132941)
2023-08-25 [email protected] Dispose overlay entries (flutter/flutter#132826)
2023-08-25 [email protected] Roll Flutter Engine from 0f8962208a44 to cb58abd77326 (3 revisions) (flutter/flutter#133320)
2023-08-25 [email protected] Roll Flutter Engine from 09e620d26834 to 0f8962208a44 (2 revisions) (flutter/flutter#133309)
2023-08-25 [email protected] Roll Flutter Engine from 9bcefc74b772 to 09e620d26834 (1 revision) (flutter/flutter#133307)
2023-08-25 [email protected] Roll Flutter Engine from 1382d6d79408 to 9bcefc74b772 (2 revisions) (flutter/flutter#133305)
2023-08-25 [email protected] Allow passing verbose log from flutter daemon. (flutter/flutter#132828)
2023-08-25 [email protected] Roll Flutter Engine from b8ec4da8866c to 1382d6d79408 (1 revision) (flutter/flutter#133298)
2023-08-25 [email protected] Roll Flutter Engine from 965501a25d92 to b8ec4da8866c (11 revisions) (flutter/flutter#133296)
2023-08-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/flutter#133281)
2023-08-24 [email protected] Update the tool to know about all our new platforms (flutter/flutter#132423)
2023-08-24 [email protected] l10n-related documentation improvements (flutter/flutter#133114)
2023-08-24 [email protected] Add hover duration for `Inkwell` widget (flutter/flutter#132176)
2023-08-24 [email protected] [web] benchmark the benchmark harness overhead (flutter/flutter#132999)
2023-08-24 [email protected] Users of ChangeNotifier should dispatch event of object creation in constructor. (flutter/flutter#133210)
2023-08-24 49699333+dependabot[bot]@users.noreply.github.com Bump activesupport from 6.1.7.3 to 6.1.7.6 in /dev/ci/mac (flutter/flutter#133225)
2023-08-24 [email protected] Remove `ImageProvider.load`, `DecoderCallback` and `PaintingBinding.instantiateImageCodec` (flutter/flutter#132679)
2023-08-24 [email protected] Roll Flutter Engine from aa98a9d2e86f to 965501a25d92 (24 revisions) (flutter/flutter#133272)
2023-08-24 [email protected] handle exceptions raised while searching for configured android studio (flutter/flutter#133180)
2023-08-24 [email protected] Fix mac tool_integration_tests with Xcode 15 (flutter/flutter#133217)
2023-08-24 [email protected] Roll Packages from 3060b1a to 383bffa (3 revisions) (flutter/flutter#133256)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
afa3789 Users of ChangeNotifier should dispatch event of object creat…
6c94cef 
…ion in constructor. (flutter/flutter#133210)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @goderbauer