Skip to content

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 23, 2023

Part of #133171

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. labels Aug 23, 2023
@Piinks Piinks requested a review from goderbauer August 23, 2023 19:46
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 25, 2023

auto label is removed for flutter/flutter/133183, due to - The status or check suite Linux web_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2023
@Piinks
Copy link
Contributor Author

Piinks commented Aug 25, 2023

Confirmed the failing check here is unrelated. Merging manually.

@Piinks Piinks merged commit 72bd360 into flutter:master Aug 25, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 26, 2023
flutter/flutter@61d9f55...229b74d

2023-08-26 [email protected] Roll Flutter Engine from e280ed21f923 to c9b584d59219 (1 revision) (flutter/flutter#133380)
2023-08-26 [email protected] Roll Flutter Engine from 63fdf8a6701c to e280ed21f923 (3 revisions) (flutter/flutter#133378)
2023-08-26 [email protected] _SelectableFragment should dispatch creation in constructor. (flutter/flutter#133351)
2023-08-25 [email protected] Roll Flutter Engine from 53595c937df1 to 63fdf8a6701c (1 revision) (flutter/flutter#133366)
2023-08-25 [email protected] Roll Flutter Engine from 1ec7b89f3a6b to 53595c937df1 (4 revisions) (flutter/flutter#133362)
2023-08-25 [email protected] Roll Flutter Engine from 1471967afb9b to 1ec7b89f3a6b (6 revisions) (flutter/flutter#133355)
2023-08-25 [email protected] Fix locking to work with flutter and dart running simultaneously (flutter/flutter#133350)
2023-08-25 [email protected] Adds callback onWillAcceptWithDetails in DragTarget. (flutter/flutter#131545)
2023-08-25 [email protected] Remove deprecated onPlatformMessage from TestWindow and TestPlatformDispatcher (flutter/flutter#133183)
2023-08-25 [email protected] Remove deprecated androidOverscrollIndicator from ScrollBehaviors (flutter/flutter#133181)
2023-08-25 [email protected] Add an example showing how to use a MatrixTransition. (flutter/flutter#132874)
2023-08-25 [email protected] Roll Flutter Engine from 3dcd2179336d to 1471967afb9b (3 revisions) (flutter/flutter#133342)
2023-08-25 [email protected] Roll Flutter Engine from 33fca02451ef to 3dcd2179336d (3 revisions) (flutter/flutter#133340)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants