Skip to content

Remove deprecated androidOverscrollIndicator from ScrollBehaviors #133181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Piinks merged 2 commits into from
Aug 25, 2023
Merged

Remove deprecated androidOverscrollIndicator from ScrollBehaviors #133181

Piinks merged 2 commits into from
Aug 25, 2023

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 23, 2023

Part of #133171

The replacement is to use the ThemeData.useMaterial3 flag, or override the buildOverscrollIndicator method of ScrollBehavior.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. c: API break Backwards-incompatible API changes f: scrolling Viewports, list views, slivers, etc. c: tech-debt Technical debt, code quality, testing, etc. labels Aug 23, 2023
@Piinks Piinks requested a review from HansMuller August 23, 2023 19:28
@Piinks Piinks mentioned this pull request Aug 23, 2023
Closed
HansMuller
HansMuller approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 23, 2023

auto label is removed for flutter/flutter/133181, due to - The status or check suite Linux docs_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

Piinks
Piinks commented Aug 23, 2023
View reviewed changes
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 24, 2023

auto label is removed for flutter/flutter/133181, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 24, 2023

auto label is removed for flutter/flutter/133181, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks force-pushed the overscrollDeprecations branch from b33618a to fc15c2d Compare August 24, 2023 21:55
Piinks
Piinks commented Aug 24, 2023
View reviewed changes
@XilaiZhang
Copy link
Contributor

XilaiZhang commented Aug 24, 2023

thanks for reporting on the Google testing entries! sent cl/559877000 for review.

The merge conflict reported was due to flutter roll having a few days' latency. (some other PRs touched the same group of files, but they haven't rolled into google 3 codebase yet.)
There is a section on https://github.com/flutter/flutter/wiki/Understanding-Google-Testing that offers 3 options when a merge conflict happens. but feel free to just override the google testing check.

@Piinks Piinks force-pushed the overscrollDeprecations branch from 5ab79b8 to 1cbcfd0 Compare August 25, 2023 19:07
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 25, 2023

auto label is removed for flutter/flutter/133181, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor Author

Piinks commented Aug 25, 2023

The Google testing shard is broken, merging manually.

@Piinks Piinks merged commit 721016c into flutter:master Aug 25, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2023
@engine-flutter-autoroll
721016c Remove deprecated androidOverscrollIndicator from ScrollBehav…
ac09089 
…iors (flutter/flutter#133181)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 26, 2023
@engine-flutter-autoroll
Roll Flutter from 61d9f55 to 229b74d (13 revisions) (#4776)
c80df44 
flutter/flutter@61d9f55...229b74d

2023-08-26 [email protected] Roll Flutter Engine from e280ed21f923 to c9b584d59219 (1 revision) (flutter/flutter#133380)
2023-08-26 [email protected] Roll Flutter Engine from 63fdf8a6701c to e280ed21f923 (3 revisions) (flutter/flutter#133378)
2023-08-26 [email protected] _SelectableFragment should dispatch creation in constructor. (flutter/flutter#133351)
2023-08-25 [email protected] Roll Flutter Engine from 53595c937df1 to 63fdf8a6701c (1 revision) (flutter/flutter#133366)
2023-08-25 [email protected] Roll Flutter Engine from 1ec7b89f3a6b to 53595c937df1 (4 revisions) (flutter/flutter#133362)
2023-08-25 [email protected] Roll Flutter Engine from 1471967afb9b to 1ec7b89f3a6b (6 revisions) (flutter/flutter#133355)
2023-08-25 [email protected] Fix locking to work with flutter and dart running simultaneously (flutter/flutter#133350)
2023-08-25 [email protected] Adds callback onWillAcceptWithDetails in DragTarget. (flutter/flutter#131545)
2023-08-25 [email protected] Remove deprecated onPlatformMessage from TestWindow and TestPlatformDispatcher (flutter/flutter#133183)
2023-08-25 [email protected] Remove deprecated androidOverscrollIndicator from ScrollBehaviors (flutter/flutter#133181)
2023-08-25 [email protected] Add an example showing how to use a MatrixTransition. (flutter/flutter#132874)
2023-08-25 [email protected] Roll Flutter Engine from 3dcd2179336d to 1471967afb9b (3 revisions) (flutter/flutter#133342)
2023-08-25 [email protected] Roll Flutter Engine from 33fca02451ef to 3dcd2179336d (3 revisions) (flutter/flutter#133340)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
721016c Remove deprecated androidOverscrollIndicator from ScrollBehav…
4246d78 
…iors (flutter/flutter#133181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @XilaiZhang @HansMuller