Skip to content

Remove deprecated TestWindow.textScaleFactorTestValue/TestWindow.clearTextScaleFactorTestValue #133176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Sep 1, 2023
Merged

Remove deprecated TestWindow.textScaleFactorTestValue/TestWindow.clearTextScaleFactorTestValue #133176

auto-submit merged 2 commits into from
Sep 1, 2023

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Aug 23, 2023

Part of: #133171

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 23, 2023
@Piinks Piinks mentioned this pull request Aug 23, 2023
Closed
@Renzo-Olivares Renzo-Olivares mentioned this pull request Aug 24, 2023
Merged
@Renzo-Olivares Renzo-Olivares marked this pull request as ready for review August 30, 2023 13:46
Piinks
Piinks approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once customer checks are clear! :)

@Renzo-Olivares Renzo-Olivares force-pushed the deprecate-textScaleFactor branch from 46471df to 9fbdf93 Compare September 1, 2023 19:13
@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit auto-submit bot merged commit 959cdb7 into flutter:master Sep 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
5ccb5c4 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
e176b6d 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
76859c4 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
3747936 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
347d338 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
3978438 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
167a994 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
f7329c9 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
6a97c76 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
1b9378e 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
3e2af7e 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
57ba032 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
cf6c7e9 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
3d5c980 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
8397b35 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
ad6ad4b 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
42f62d1 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
4f221ab 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
dbf0355 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
1458dc4 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
632dbc8 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
1bfca44 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
31e3f1f 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
959cdb7 Remove deprecated TestWindow.textScaleFactorTestValue/TestWin…
5241a31 
…dow.clearTextScaleFactorTestValue (flutter/flutter#133176)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Renzo-Olivares @Piinks