Skip to content

Add a showBottomSheet for consistency with showModalBottomSheet.#13314

Merged
Hixie merged 1 commit into
flutter:masterfrom
Hixie:showBottomSheet
Dec 4, 2017
Merged

Add a showBottomSheet for consistency with showModalBottomSheet.#13314
Hixie merged 1 commit into
flutter:masterfrom
Hixie:showBottomSheet

Conversation

@Hixie

@Hixie Hixie commented Dec 2, 2017

Copy link
Copy Markdown
Contributor

Also, extra docs.

Fixes #13279
Fixes #2115

@abarth

abarth commented Dec 4, 2017

Copy link
Copy Markdown
Contributor

LGTM

@Hixie

Hixie commented Dec 4, 2017

Copy link
Copy Markdown
Contributor Author

Thanks!

@Hixie
Hixie merged commit c44f15e into flutter:master Dec 4, 2017
@Hixie
Hixie deleted the showBottomSheet branch December 4, 2017 21:43
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 8, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 9, 2019
engine-flutter-autoroll added a commit that referenced this pull request Nov 9, 2019
[email protected]:flutter/engine.git/compare/5f5713e33971...af04338

git log 5f5713e..af04338 --no-merges --oneline
2019-11-08 [email protected] Manual roll of Dart e68ca9b652acdb642668a6acb5f630d5be6c03da...fa4379946109467c8a48f20f19d83d7c72968a3e (flutter-team-archive/engine#13756)
2019-11-08 [email protected] Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13755)" (flutter-team-archive/engine#13757)
2019-11-08 [email protected] [web] Support gif/webp animations, Speed up image drawing in BitmapCanvas.  (flutter-team-archive/engine#13748)
2019-11-08 [email protected] Reland "Guarding EAGLContext used by Flutter #13314" (flutter-team-archive/engine#13755)
2019-11-08 [email protected] Move TextRange from the framework to dart:ui. (flutter-team-archive/engine#13747)
2019-11-08 [email protected] Roll src/third_party/skia 8c1e265f6f81..c88d1774ed50 (7 commits) (flutter-team-archive/engine#13754)
2019-11-08 [email protected] Revert "Always use `IOSGLContextSwitch` to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)" (flutter-team-archive/engine#13753)
2019-11-08 [email protected] Always use `IOSGLContextSwitch` to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (flutter-team-archive/engine#13314)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
engine-flutter-autoroll added a commit that referenced this pull request Nov 11, 2019
[email protected]:flutter/engine.git/compare/31cd2dfca22a...eec36a8

git log 31cd2df..eec36a8 --no-merges --oneline
2019-11-09 [email protected] Roll fuchsia/sdk/core/mac-amd64 from eq_Rz... to xC_an... (flutter-team-archive/engine#13771)
2019-11-09 [email protected] Roll src/third_party/skia 4135cf0b57c2..0fd4f01b9b83 (1 commits) (flutter-team-archive/engine#13770)
2019-11-09 [email protected] Reland "Guarding EAGLContext used by Flutter #13314" (flutter-team-archive/engine#13759)
2019-11-09 [email protected] Point old plugin registry accessors to new embedding plugin accessors.  (#44225) (flutter-team-archive/engine#13739)
2019-11-09 [email protected] Revert "[fuchsia] Temporarily disable intl provider (#13696)" (flutter-team-archive/engine#13721)
2019-11-09 [email protected] Turn on RasterCache based on view hierarchy (flutter-team-archive/engine#13762)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This was referenced Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

3 participants