Skip to content

Conversation

@polina-c
Copy link
Contributor

No description provided.

@polina-c polina-c requested a review from goderbauer August 22, 2023 19:12
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs labels Aug 22, 2023
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. labels Aug 22, 2023
@polina-c polina-c added autosubmit Merge PR when tree becomes green via auto submit App and removed a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. labels Aug 22, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 22, 2023

auto label is removed for flutter/flutter/133073, due to - The status or check suite Linux framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. labels Aug 22, 2023
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 22, 2023
@auto-submit auto-submit bot merged commit 2afded6 into flutter:master Aug 23, 2023
@polina-c polina-c deleted the leaking_recording branch August 23, 2023 01:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 23, 2023
flutter/flutter@54c98d7...bd836cc

2023-08-23 [email protected] Roll Packages from c730a90 to 3060b1a (4 revisions) (flutter/flutter#133149)
2023-08-23 [email protected] Roll Flutter Engine from 7d56840865d2 to 72a06427bd37 (8 revisions) (flutter/flutter#133139)
2023-08-23 [email protected] Manual roll Flutter Engine from b190f9015049 to 7d56840865d2 (15 revisions) (flutter/flutter#133106)
2023-08-23 [email protected] Reference AppLifecycleListener from widgets library (flutter/flutter#132995)
2023-08-23 [email protected] Support disabling animations in the CLI (flutter/flutter#132239)
2023-08-23 [email protected] Don't run on Samsung S10, shift to Pixel 7 Pro (flutter/flutter#133085)
2023-08-23 [email protected] Add test to mark recording as leaking. (flutter/flutter#133073)
2023-08-22 [email protected] Revert "[gallery] roll gallery to  ecfb9e5352bd12032301b12b30d5853d83d89bda" (flutter/flutter#133095)
2023-08-22 [email protected] [gallery] roll gallery to  ecfb9e5352bd12032301b12b30d5853d83d89bda (flutter/flutter#133083)
2023-08-22 [email protected] Update default menu text styles for Material 3 (flutter/flutter#131930)
2023-08-22 [email protected] Roll Flutter Engine from 28b8bd5d5d91 to b190f9015049 (3 revisions) (flutter/flutter#133078)
2023-08-22 [email protected] Fix `FlexibleSpaceBar.title` doesn't respect the leading widget (flutter/flutter#132573)
2023-08-22 [email protected] Roll Flutter Engine from 21437d384b56 to 28b8bd5d5d91 (1 revision) (flutter/flutter#133075)
2023-08-22 [email protected] Roll Flutter Engine from 090754879679 to 21437d384b56 (1 revision) (flutter/flutter#133072)
2023-08-22 [email protected] Add support for `Future<List<int>?>` to `MatchesGoldenFile` (flutter/flutter#132965)
2023-08-22 [email protected] Roll Packages from e26f3b9 to c730a90 (3 revisions) (flutter/flutter#133067)
2023-08-22 [email protected] Roll Flutter Engine from ff375bf5d8eb to 090754879679 (1 revision) (flutter/flutter#133066)
2023-08-22 [email protected] Increase heap size for examples/flutter_view gradle build (flutter/flutter#133064)
2023-08-22 [email protected] Roll Flutter Engine from c5e0152b01f4 to ff375bf5d8eb (4 revisions) (flutter/flutter#133062)
2023-08-22 [email protected] Fix memory leak in Form (flutter/flutter#132987)
2023-08-22 [email protected] Re-enable Xcode Debug tests (flutter/flutter#132523)
2023-08-22 [email protected] Increase heap for gradle in examples/platform_view (flutter/flutter#133052)
2023-08-22 [email protected] Cover more tests with leak tracking. (flutter/flutter#132806)
2023-08-22 [email protected] Roll Flutter Engine from f5f099a4a5e3 to c5e0152b01f4 (4 revisions) (flutter/flutter#133049)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants