Skip to content

[CP] Fix visual overflow for SliverMainAxisGroup (#132989) #133057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
XilaiZhang merged 1 commit into from
Sep 5, 2023
Merged

[CP] Fix visual overflow for SliverMainAxisGroup (#132989) #133057

XilaiZhang merged 1 commit into from
Sep 5, 2023

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 22, 2023 •
edited
Loading

Cherry picks #132989 which fixes #132788

Fixes #133058

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks
Fix visual overflow for SliverMainAxisGroup (flutter#132989)
22bafdd 
Fixes flutter#132788

The SliverGeometry was not set properly for SliverMainAxisGroup. Omitting hasVisualOverflow affected the Viewport's choice to apply a clip, leading to the sliver being rendered outside of the bounds of the viewport.
@Piinks Piinks added the cp: review Cherry-picks in the review queue label Aug 22, 2023
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 22, 2023
@Piinks Piinks mentioned this pull request Aug 22, 2023
Closed
@Piinks Piinks changed the title Fix visual overflow for SliverMainAxisGroup (#132989) [CP] Fix visual overflow for SliverMainAxisGroup (#132989) Aug 22, 2023
@itsjustkevin itsjustkevin removed the cp: review Cherry-picks in the review queue label Aug 22, 2023
HansMuller
HansMuller approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang XilaiZhang merged commit 441432b into flutter:flutter-3.13-candidate.0 Sep 5, 2023
@XilaiZhang
Copy link
Contributor

XilaiZhang commented Sep 5, 2023

thanks for the cp! merged. As a side note it is recommended to merge early once the cp is approved. Thank you!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
441432b5b [CP] Fix visual overflow for SliverMainAxisGroup (#132989) (f…
de65f62 
…lutter/flutter#133057)
@Piinks
Copy link
Contributor Author

Piinks commented Sep 11, 2023

As a side note it is recommended to merge early once the cp is approved.

Did I miss a step in the documented process? I was wondering why it took so long for this to be merged.

As I understand it, it is up to the release team to merge it.

https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process

@XilaiZhang
Copy link
Contributor

XilaiZhang commented Sep 11, 2023

oh thanks for providing the doc!
umm @itsjustkevin can we update the doc with a section to merge the cp pull request once its approved? thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @XilaiZhang @HansMuller @itsjustkevin