Skip to content

Tooltip: Have preferBelow default to false instead of true #133007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe wants to merge 1 commit into from
Closed

Tooltip: Have preferBelow default to false instead of true #133007

chrisbobbe wants to merge 1 commit into from

Conversation

@chrisbobbe
Copy link
Contributor

@chrisbobbe chrisbobbe commented Aug 21, 2023

Fixes #133006.

Also, update the dartdoc on preferBelow to mention the existing role of [TooltipThemeData.preferBelow].

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chrisbobbe
Tooltip: Have preferBelow default to false instead of true
c79fbf9 
Fixes flutter#133006.

Also, update the dartdoc on `preferBelow` to mention the existing
role of [TooltipThemeData.preferBelow].
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 21, 2023
@chrisbobbe chrisbobbe mentioned this pull request Aug 21, 2023
Merged
TahaTesser
TahaTesser approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser requested a review from HansMuller August 22, 2023 07:38
@TahaTesser
Copy link
Member

TahaTesser commented Aug 22, 2023

We'll need a second review before landing this.

@HansMuller
Copy link
Contributor

HansMuller commented Aug 22, 2023

This is a sensible change but it's also a breaking change - the "Google Testing" failures are evidence of that. I think we'd be better off with an example that showed how to configure an app's TooltipTheme to do the right thing by default

@chrisbobbe
Copy link
Contributor Author

chrisbobbe commented Oct 2, 2023 •
edited
Loading

Makes sense. I plan to send a PR for that docs change and close #133006 as WONTFIX, then.

(edit: sent #135879)

@chrisbobbe chrisbobbe closed this Oct 2, 2023
This was referenced Oct 2, 2023
Merged
Closed
chrisbobbe added a commit to chrisbobbe/flutter that referenced this pull request Nov 2, 2023
@chrisbobbe
Tooltip docs: Recommend setting preferBelow to false in theme
64c5404 
As requested at:
  flutter#133007 (comment)
auto-submit bot pushed a commit that referenced this pull request Nov 3, 2023
@chrisbobbe
Tooltip docs: Recommend setting preferBelow to false in theme (#135879)
e7f9982 
As discussed at #133007 (comment), this is a docs change meant to help people in the absence of a fix for #133006, which is being closed as WONTFIX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tooltip: Have preferBelow default to false instead of true

3 participants

@chrisbobbe @TahaTesser @HansMuller