Add deleteBackwardByDecomposingPreviousCharacter mapping for tests #132919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
Contributor
Author
|
@Renzo-Olivares Could you take a look? |
Renzo-Olivares
approved these changes
Aug 21, 2023
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM thanks for the contribution!
11 tasks
justinmc
approved these changes
Aug 21, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍 Whoops, thanks for fixing this!
Contributor
|
I don't think that selector is mapped to an intent in the framework. Do you have plans to dispatch that event as an |
Contributor
Author
|
@LongCatIsLooong I'm handling the selector in performSelector directly. |
Contributor
|
I see. Could you rebase the branch to fix Google testing? |
angelosilvestre
force-pushed
the
test_selector
branch
from
9d170a6 to
08c554a
Compare
Contributor
Author
|
@LongCatIsLooong Done. |
LongCatIsLooong
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/132919, due to - The status or check suite Linux web_canvaskit_tests_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
LongCatIsLooong
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 22, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 22, 2023
flutter/flutter@5e6d88d...54c98d7 2023-08-22 [email protected] Roll Flutter Engine from 447981acbf36 to f5f099a4a5e3 (1 revision) (flutter/flutter#133035) 2023-08-22 [email protected] Roll Flutter Engine from 5e84d733ef67 to 447981acbf36 (2 revisions) (flutter/flutter#133031) 2023-08-22 [email protected] Roll Flutter Engine from e183e8a94093 to 5e84d733ef67 (1 revision) (flutter/flutter#133030) 2023-08-22 [email protected] Roll Flutter Engine from 454e0e35f8e4 to e183e8a94093 (2 revisions) (flutter/flutter#133026) 2023-08-22 [email protected] Roll Flutter Engine from 857840db5574 to 454e0e35f8e4 (1 revision) (flutter/flutter#133020) 2023-08-22 [email protected] Roll Flutter Engine from 1ab054967c1d to 857840db5574 (2 revisions) (flutter/flutter#133018) 2023-08-22 [email protected] Roll Flutter Engine from 5a292e42a593 to 1ab054967c1d (1 revision) (flutter/flutter#133014) 2023-08-22 [email protected] Fix visual overflow for SliverMainAxisGroup (flutter/flutter#132989) 2023-08-22 [email protected] Roll Flutter Engine from e5929d83e9b7 to 5a292e42a593 (3 revisions) (flutter/flutter#133010) 2023-08-22 [email protected] Always require `--local-engine-host` if `--local-engine` (flutter/flutter#133003) 2023-08-22 [email protected] Roll Flutter Engine from 55b84268f2a6 to e5929d83e9b7 (3 revisions) (flutter/flutter#133005) 2023-08-21 [email protected] Roll Flutter Engine from e5f690b829e5 to 55b84268f2a6 (1 revision) (flutter/flutter#133000) 2023-08-21 [email protected] Add deleteBackwardByDecomposingPreviousCharacter mapping for tests (flutter/flutter#132919) 2023-08-21 [email protected] Roll Flutter Engine from fc75109c3a1e to e5f690b829e5 (1 revision) (flutter/flutter#132996) 2023-08-21 [email protected] Roll Flutter Engine from 2388b9db2be7 to fc75109c3a1e (3 revisions) (flutter/flutter#132992) 2023-08-21 [email protected] Roll Flutter Engine from 210f5a8aa245 to 2388b9db2be7 (6 revisions) (flutter/flutter#132986) 2023-08-21 [email protected] Update `ExpansionPanel` example for the updated `expansionCallback` callback (flutter/flutter#132837) 2023-08-21 [email protected] Change gradle lockfile generation script to use --config-only flag (flutter/flutter#132967) 2023-08-21 [email protected] Roll Flutter Engine from 0290d0bd79ee to 210f5a8aa245 (1 revision) (flutter/flutter#132973) 2023-08-21 [email protected] Docs on iOS's directional quote characters (flutter/flutter#132869) 2023-08-21 [email protected] Bump memory usage for flutter gallery (flutter/flutter#132968) 2023-08-21 [email protected] When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK (flutter/flutter#127456) 2023-08-21 [email protected] Roll Flutter Engine from a9b00783bc7c to 0290d0bd79ee (1 revision) (flutter/flutter#132962) 2023-08-21 [email protected] Roll Packages from 4c16f3e to e26f3b9 (5 revisions) (flutter/flutter#132960) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
MacOSTestTextInputKeyHandler, there are some mappings from shortcuts to generate macOS selectors. However,ctrl + backspaceisn't mapped todeleteBackwardByDecomposingPreviousCharacter:.This PR adds the mapping for
deleteBackwardByDecomposingPreviousCharacter:.Fixes: #132917
Pre-launch Checklist
///).