SelectionArea on iOS should toggle the context menu when tapping on the previous selection #132851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
chunhtai
approved these changes
Aug 18, 2023
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, just have a question
| () => TapGestureRecognizer(debugOwner: this), | ||
| (TapGestureRecognizer instance) { | ||
| instance.onTap = _clearSelection; | ||
| instance.onTapUp = (TapUpDetails details) { |
Contributor
There was a problem hiding this comment.
How would this interact with the tap to collapse selection in the previous pr?
Contributor
Author
There was a problem hiding this comment.
It would look something like this, replacing the else branch with the _clearSelection.
instance.onTapUp = (TapUpDetails details) {
if (defaultTargetPlatform == TargetPlatform.iOS && _positionIsOnActiveSelection(globalPosition: details.globalPosition)) {
// On iOS when the tap occurs on the previous selection instead of
// moving the selection, the context menu will be toggled.
final bool toolbarIsVisible = _selectionOverlay?.toolbarIsVisible ?? false;
if (toolbarIsVisible) {
hideToolbar(false);
} else {
_showToolbar(location: details.globalPosition);
}
} else {
hideToolbar();
_selectPositionAt(offset: details.globalPosition);
}
};This toggle behavior still holds true even with the collapsing selection at single tap pr.
justinmc
approved these changes
Aug 18, 2023
| instance.onTap = _clearSelection; | ||
| instance.onTapUp = (TapUpDetails details) { | ||
| if (defaultTargetPlatform == TargetPlatform.iOS && _positionIsOnActiveSelection(globalPosition: details.globalPosition)) { | ||
| // On iOS when the tap occurs on the previous selection instead of |
Contributor
There was a problem hiding this comment.
Super readability nit:
Suggested change
| // On iOS when the tap occurs on the previous selection instead of | |
| // On iOS when the tap occurs on the previous selection, instead of |
Renzo-Olivares
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/132851, due to - The status or check suite Linux web_canvaskit_tests_0 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Renzo-Olivares
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2023
…ing on the previous selection (flutter/flutter#132851)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2023
…ing on the previous selection (flutter/flutter#132851)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 19, 2023
flutter/flutter@5a556f8...6f227c0 2023-08-19 [email protected] Space character should be optional when tree shaking fonts (flutter/flutter#132880) 2023-08-19 [email protected] Roll Flutter Engine from 654d3a2c8494 to f4bffdcf8536 (5 revisions) (flutter/flutter#132876) 2023-08-18 [email protected] SelectionArea on iOS should toggle the context menu when tapping on the previous selection (flutter/flutter#132851) 2023-08-18 [email protected] Forward port API docs creation realm handling from prior script (flutter/flutter#132867) 2023-08-18 [email protected] Roll Flutter Engine from 72c4e61fdbfa to 654d3a2c8494 (3 revisions) (flutter/flutter#132868) 2023-08-18 [email protected] Roll Flutter Engine from 83fdadaf12f0 to 72c4e61fdbfa (2 revisions) (flutter/flutter#132861) 2023-08-18 [email protected] Updates app link gradle tasks and remove vm services (flutter/flutter#131805) 2023-08-18 [email protected] Roll Flutter Engine from 58f7d8ee3e2c to 83fdadaf12f0 (7 revisions) (flutter/flutter#132857) 2023-08-18 [email protected] doc: add flag params (flutter/flutter#132485) 2023-08-18 [email protected] Add a new MatrixTransition and refactor ScaleTransition and RotationT� (flutter/flutter#131084) 2023-08-18 [email protected] fixes l10n for CupertinoDatePicker in monthYear mode (flutter/flutter#130934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…ing on the previous selection (flutter/flutter#132851)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-08-18.at.2.34.33.AM.mov
Related: #129583
Pre-launch Checklist
///).