Fix --preview-dart2 option handling for ios profile/release. #13285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmarkov
approved these changes
Dec 1, 2017
| DebuggingOptions debuggingOptions, | ||
| Map<String, dynamic> platformArgs, | ||
| bool prebuiltApplication: false, | ||
| bool previewDart2: false, |
Contributor
There was a problem hiding this comment.
Also consider cleaning up 'previewDart2' argument in FuchsiaDevice.startApp() in fuchsia_device.dart.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…#13285) * Fix --preview-dart2 option handling for ios profile/release. * Remove unused parameter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to explicitly pass
previewDart2option - it is part ofBuildInfowhich is populated based on--preview-dart-2option passed. We need to use it fromBuildInfoso it works correctly forbuild run --preview-dart-2 --profile/--release.