Fix `cancelButtonStyle` & `confirmButtonStyle` properties from `TimePickerTheme` aren't working #132843

TahaTesser · 2023-08-18T13:19:06Z

fixes TimePickerThemeData action buttons styles aren't working

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        useMaterial3: true,
        timePickerTheme: TimePickerThemeData(
          cancelButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(4)),
              side: BorderSide(color: Colors.red),
            ),
            backgroundColor: Colors.white,
            foregroundColor: Colors.red,
            elevation: 3,
            shadowColor: Colors.red,
          ),
          confirmButtonStyle: TextButton.styleFrom(
            shape: const RoundedRectangleBorder(
              borderRadius: BorderRadius.all(Radius.circular(4)),
            ),
            backgroundColor: Colors.green[700],
            foregroundColor: Colors.white,
            elevation: 3,
            shadowColor: Colors.green[700],
          ),
        ),
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: TimePickerDialog(initialTime: TimeOfDay.now()),
      ),
    );
  }
}

Before (action buttons don't use the style from the `TimePickerTheme`)

After (action buttons use the style from the `TimePickerTheme`)

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

HansMuller

LGTM

…nfirmButtonStyle` aren't working

…m `TimePickerTheme` aren't working (flutter/flutter#132843)

flutter/flutter@1fe2495...c175cf8 2023-08-31 [email protected] Ignore macOS Cocoapods linting failure on DT_TOOLCHAIN_DIR error (flutter/flutter#133588) 2023-08-31 [email protected] `InputDecorationTheme.isCollapsed` doesn't work if `InputDecoration.isCollapsed` is not provided. (flutter/flutter#133189) 2023-08-31 [email protected] Roll Flutter Engine from 5156c03344eb to 772d5e996af8 (1 revision) (flutter/flutter#133752) 2023-08-31 [email protected] Roll Flutter Engine from 1917fa95ea55 to 5156c03344eb (2 revisions) (flutter/flutter#133745) 2023-08-31 [email protected] Roll Flutter Engine from 1f1071d3f5ba to 1917fa95ea55 (2 revisions) (flutter/flutter#133739) 2023-08-31 [email protected] Roll Flutter Engine from e88b21b6d4e8 to 1f1071d3f5ba (1 revision) (flutter/flutter#133737) 2023-08-31 [email protected] Roll Flutter Engine from 0559a733c888 to e88b21b6d4e8 (1 revision) (flutter/flutter#133735) 2023-08-31 [email protected] Roll Flutter Engine from 3b75e3de7ef3 to 0559a733c888 (1 revision) (flutter/flutter#133734) 2023-08-31 [email protected] [framework] use ImageFilter for stretch overscroll. (flutter/flutter#133613) 2023-08-31 [email protected] Roll Flutter Engine from 73e86369614d to 3b75e3de7ef3 (2 revisions) (flutter/flutter#133724) 2023-08-31 [email protected] Roll Flutter Engine from 8f1b77b1ac69 to 73e86369614d (1 revision) (flutter/flutter#133720) 2023-08-31 [email protected] Roll Flutter Engine from d37cef84d40d to 8f1b77b1ac69 (1 revision) (flutter/flutter#133714) 2023-08-31 [email protected] Mark leak in _DraggableScrollableSheetState. (flutter/flutter#133693) 2023-08-30 [email protected] Mark routing test as leaking. (flutter/flutter#133697) 2023-08-30 [email protected] Roll Flutter Engine from b63eee2e31cc to d37cef84d40d (3 revisions) (flutter/flutter#133706) 2023-08-30 [email protected] _RawAutocompleteState should dispose _highlightedOptionIndex. (flutter/flutter#133700) 2023-08-30 [email protected] Forward-fix a test that will break with an engine roll. (flutter/flutter#133619) 2023-08-30 [email protected] Fix `cancelButtonStyle` & `confirmButtonStyle` properties from `TimePickerTheme` aren't working (flutter/flutter#132843) 2023-08-30 [email protected] Updated DropdownMenu example and added a test (flutter/flutter#133592) 2023-08-30 [email protected] Add `cancelButtonStyle` & `confirmButtonStyle` to the `DatePickerThemeData` (flutter/flutter#132847) 2023-08-30 [email protected] Roll Flutter Engine from 31d5662dcb53 to b63eee2e31cc (1 revision) (flutter/flutter#133692) 2023-08-30 [email protected] Fixing memory leak in EditableTextState (flutter/flutter#131377) 2023-08-30 [email protected] Roll Flutter Engine from 69f04bdfe952 to 31d5662dcb53 (14 revisions) (flutter/flutter#133683) 2023-08-30 [email protected] Expose barrierDismissible in PageRoute constructor (flutter/flutter#133659) 2023-08-30 [email protected] Update the infrastructure issue template (flutter/flutter#133519) 2023-08-30 [email protected] Reland "Remove ImageProvider.load, DecoderCallback and `PaintingBinding.instantiateImageCodec` (#132679) (reverted in #133482) (flutter/flutter#133605) 2023-08-30 [email protected] Roll Packages from d7d3150 to 64af59e (4 revisions) (flutter/flutter#133675) 2023-08-30 [email protected] Update & improve `TabBar.labelColor` tests (flutter/flutter#133668) 2023-08-30 [email protected] Bump gradle heap size limits in templates (flutter/flutter#133671) 2023-08-30 [email protected] Marks Windows module_test to be flaky (flutter/flutter#133640) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…m `TimePickerTheme` aren't working (flutter/flutter#132843)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 18, 2023

TahaTesser mentioned this pull request Aug 18, 2023

Unable to adjust the color for "Cancel" and "Ok" button in datePicker dialog #127739

Closed

2 tasks

TahaTesser requested a review from gspencergoog August 18, 2023 13:26

TahaTesser force-pushed the fix_time_picker_theme_action_styles branch 3 times, most recently from d9d7816 to 979367c Compare August 18, 2023 14:00

TahaTesser changed the title ~~Fix TimePickerThemeData.cancelButtonStyle & TimePickerThemeData.confirmButtonStyle aren't working~~ Fix cancelButtonStyle & confirmButtonStyle properties from TimePickerTheme aren't working Aug 18, 2023

TahaTesser requested a review from HansMuller August 30, 2023 14:05

HansMuller approved these changes Aug 30, 2023

View reviewed changes

TahaTesser force-pushed the fix_time_picker_theme_action_styles branch from 979367c to c0cd83a Compare August 30, 2023 16:39

Fix TimePickerThemeData.cancelButtonStyle & `TimePickerThemeData.co…

8e936ff

…nfirmButtonStyle` aren't working

TahaTesser force-pushed the fix_time_picker_theme_action_styles branch from c0cd83a to 8e936ff Compare August 30, 2023 21:16

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2023

auto-submit bot merged commit d7a3a68 into flutter:master Aug 30, 2023

TahaTesser deleted the fix_time_picker_theme_action_styles branch August 30, 2023 22:23

engine-flutter-autoroll mentioned this pull request Aug 31, 2023

Roll Flutter from 1fe24956ac46 to c175cf87a6a3 (30 revisions) flutter/packages#4825

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2023

d7a3a68 Fix cancelButtonStyle & confirmButtonStyle properties fro…

8cc83d9

…m `TimePickerTheme` aren't working (flutter/flutter#132843)

HansMuller mentioned this pull request Sep 1, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

d7a3a68 Fix cancelButtonStyle & confirmButtonStyle properties fro…

e5a53cb

…m `TimePickerTheme` aren't working (flutter/flutter#132843)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix `cancelButtonStyle` & `confirmButtonStyle` properties from `TimePickerTheme` aren't working #132843

Fix `cancelButtonStyle` & `confirmButtonStyle` properties from `TimePickerTheme` aren't working #132843

Uh oh!

TahaTesser commented Aug 18, 2023

Uh oh!

HansMuller left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix cancelButtonStyle & confirmButtonStyle properties from TimePickerTheme aren't working #132843

Fix cancelButtonStyle & confirmButtonStyle properties from TimePickerTheme aren't working #132843

Uh oh!

Conversation

TahaTesser commented Aug 18, 2023

Code sample

Before (action buttons don't use the style from the TimePickerTheme)

After (action buttons use the style from the TimePickerTheme)

Pre-launch Checklist

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix `cancelButtonStyle` & `confirmButtonStyle` properties from `TimePickerTheme` aren't working #132843

Fix `cancelButtonStyle` & `confirmButtonStyle` properties from `TimePickerTheme` aren't working #132843

Before (action buttons don't use the style from the `TimePickerTheme`)

After (action buttons use the style from the `TimePickerTheme`)