Dispose overlay entries #132826
Merged
Dispose overlay entries #132826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
a: text input
Contributor
|
Would this unblock removing the leak tracking config overrides on some This PR does not modify any tests, hence why I'm asking. |
Contributor
Author
|
@navaronbracke This might be a good question for @polina-c :) |
justinmc
approved these changes
Aug 24, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for cleaning this up!
| ); | ||
|
|
||
| _overlayEntry = OverlayEntry( | ||
| _overlayEntry = OverlayEntry( |
Contributor
There was a problem hiding this comment.
Good catch on the space 👾
Contributor
|
@polina-c Is there a way to test these changes using your leak tracking tests? Or should it be test exempt? |
Contributor
|
OverlayEntry is not instrumented to be tracked for leaks yet. So, not yet. Added it to list of classes to instrument. |
Contributor
|
test-exempt: will be tracked is there a bug# to follow that work? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 25, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 25, 2023
flutter/flutter@deeb811...61d9f55 2023-08-25 [email protected] Update flutter packages to pick up latest vm_service (flutter/flutter#133335) 2023-08-25 [email protected] Roll Flutter Engine from 00f532dcaef4 to 33fca02451ef (1 revision) (flutter/flutter#133337) 2023-08-25 [email protected] Roll Flutter Engine from cb58abd77326 to 00f532dcaef4 (3 revisions) (flutter/flutter#133333) 2023-08-25 [email protected] Fix `PopupMenuItem` with a `ListTile` doesn't use the correct style. (flutter/flutter#133141) 2023-08-25 [email protected] Fix `Chip.shape`'s side is not used when provided in Material 3 (flutter/flutter#132941) 2023-08-25 [email protected] Dispose overlay entries (flutter/flutter#132826) 2023-08-25 [email protected] Roll Flutter Engine from 0f8962208a44 to cb58abd77326 (3 revisions) (flutter/flutter#133320) 2023-08-25 [email protected] Roll Flutter Engine from 09e620d26834 to 0f8962208a44 (2 revisions) (flutter/flutter#133309) 2023-08-25 [email protected] Roll Flutter Engine from 9bcefc74b772 to 09e620d26834 (1 revision) (flutter/flutter#133307) 2023-08-25 [email protected] Roll Flutter Engine from 1382d6d79408 to 9bcefc74b772 (2 revisions) (flutter/flutter#133305) 2023-08-25 [email protected] Allow passing verbose log from flutter daemon. (flutter/flutter#132828) 2023-08-25 [email protected] Roll Flutter Engine from b8ec4da8866c to 1382d6d79408 (1 revision) (flutter/flutter#133298) 2023-08-25 [email protected] Roll Flutter Engine from 965501a25d92 to b8ec4da8866c (11 revisions) (flutter/flutter#133296) 2023-08-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/flutter#133281) 2023-08-24 [email protected] Update the tool to know about all our new platforms (flutter/flutter#132423) 2023-08-24 [email protected] l10n-related documentation improvements (flutter/flutter#133114) 2023-08-24 [email protected] Add hover duration for `Inkwell` widget (flutter/flutter#132176) 2023-08-24 [email protected] [web] benchmark the benchmark harness overhead (flutter/flutter#132999) 2023-08-24 [email protected] Users of ChangeNotifier should dispatch event of object creation in constructor. (flutter/flutter#133210) 2023-08-24 49699333+dependabot[bot]@users.noreply.github.com Bump activesupport from 6.1.7.3 to 6.1.7.6 in /dev/ci/mac (flutter/flutter#133225) 2023-08-24 [email protected] Remove `ImageProvider.load`, `DecoderCallback` and `PaintingBinding.instantiateImageCodec` (flutter/flutter#132679) 2023-08-24 [email protected] Roll Flutter Engine from aa98a9d2e86f to 965501a25d92 (24 revisions) (flutter/flutter#133272) 2023-08-24 [email protected] handle exceptions raised while searching for configured android studio (flutter/flutter#133180) 2023-08-24 [email protected] Fix mac tool_integration_tests with Xcode 15 (flutter/flutter#133217) 2023-08-24 [email protected] Roll Packages from 3060b1a to 383bffa (3 revisions) (flutter/flutter#133256) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
OverlayEntryimplements aListenablethat is e.g. subscribed to by theNavigator, it should be disposed when no longer used. This PR adds the missingdispose()calls in all the places I could find they were missing.Test-exempt: adding missing dispose() methods without other functional changes
Pre-launch Checklist
///).