Skip to content

[Windows] Allow overwriting the cache's Dart SDK archive license file… #132777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 17, 2023
Merged

[Windows] Allow overwriting the cache's Dart SDK archive license file… #132777

auto-submit merged 1 commit into from
Aug 17, 2023

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Aug 17, 2023 •
edited
Loading

Relands #132669 after it was reverted by #132773. The test failures were fixed separately by #132766

Tracking issue: #132592
Cherrypick issue: #132718

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma
[Windows] Allow overwriting the cache's Dart SDK archive license file (…
a91d4a4 
…flutter#132669)

flutter/engine#43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file.

This is a short-term solution that will be cherry-picked for the next [3.14 beta release](flutter#132267). Addresses flutter#132592.

The long-term solution is tracked by flutter#132702
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 17, 2023
christopherfujino
christopherfujino approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@christopherfujino christopherfujino mentioned this pull request Aug 17, 2023
Closed
@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023
@auto-submit auto-submit bot merged commit 9e67e0e into flutter:master Aug 17, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9e67e0e [Windows] Allow overwriting the cache's Dart SDK archive lice…
bf54110 
…nse file… (flutter/flutter#132777)
@loic-sharma loic-sharma deleted the update_dart_sdk_redo branch August 17, 2023 20:12
@loic-sharma loic-sharma mentioned this pull request Aug 17, 2023
Closed
2 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
9e67e0e [Windows] Allow overwriting the cache's Dart SDK archive lice…
4e17369 
…nse file… (flutter/flutter#132777)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
9e67e0e [Windows] Allow overwriting the cache's Dart SDK archive lice…
2cfbf21 
…nse file… (flutter/flutter#132777)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
9e67e0e [Windows] Allow overwriting the cache's Dart SDK archive lice…
45256ee 
…nse file… (flutter/flutter#132777)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
9e67e0e [Windows] Allow overwriting the cache's Dart SDK archive lice…
6af5d1d 
…nse file… (flutter/flutter#132777)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
9e67e0e [Windows] Allow overwriting the cache's Dart SDK archive lice…
b89607b 
…nse file… (flutter/flutter#132777)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@yaakovschectman yaakovschectman yaakovschectman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loic-sharma @christopherfujino @yaakovschectman