Skip to content

Conversation

@yaakovschectman
Copy link
Contributor

Reverts #132669

Introduced failure on windows/mac/linux framework_library_tests.

05:41 +7318 ~22 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_bar_theme_test.dart: (tearDownAll) [E]                                                                                   
  Expected: leak free
    Actual: <Instance of 'Leaks'>
     Which: contains leaks:
            # The text is generated by leak_tracker.
            # For leak troubleshooting tips open:
            # https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md
            notDisposed:
              total: 3
              objects:
                ValueNotifier<_OverlayEntryWidgetState?>:
                  test: Constructor parameters override theme parameters
                  identityHashCode: 407433615
                FocusScopeNode:
                  test: Constructor parameters override theme parameters
                  identityHashCode: 513181650
                FocusScopeNode:
                  test: Constructor parameters override theme parameters
                  identityHashCode: 704743556
            
            
  
  package:matcher                                                                   expect
  package:flutter_test/src/widget_tester.dart 458:18                                expect
  package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 81:5  _tearDownTestingWithLeakTracking
  ===== asynchronous gap ===========================
  dart:async                                                                        _CustomZone.registerBinaryCallback
  package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 59:9  configureLeakTrackingTearDown.<fn>

@yaakovschectman yaakovschectman added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 17, 2023
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 17, 2023
@auto-submit auto-submit bot merged commit e10d74b into master Aug 17, 2023
@auto-submit auto-submit bot deleted the revert-132669-windows_update_hang branch August 17, 2023 17:26
@zanderso
Copy link
Member

The error was probably unrelated to this PR, and rather was caused by a new test order random seed for today. The tree should be made green by #132766, and then this PR can be safely relanded.

yaakovschectman added a commit that referenced this pull request Aug 17, 2023
auto-submit bot pushed a commit that referenced this pull request Aug 17, 2023
#132777)

Relands #132669 after it was reverted by #132773. The test failures were fixed separately by #132766

Tracking issue: #132592
Cherrypick issue: #132718
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

revert Autorevert PR (with "Reason for revert:" comment) tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants