Skip to content

Conversation

@zanderso
Copy link
Member

No description provided.

.ci.yaml Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this should be "cheetah"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be either (based on the values in the dimensions).

Pixel 7 Pro is more descriptive?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm hoping to keep "Pixel 7 Pro"

Copy link
Contributor

@yusuf-goog yusuf-goog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

.ci.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this build be in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this existing build from another place in the file to be next to all the other new_gallery__transition_perf benchmarks.

@zanderso zanderso force-pushed the new-gallery-pixel-7 branch from 9fa1b71 to 0a6fd00 Compare August 17, 2023 17:44
task_name: new_gallery_impeller__transition_perf

# Samsung A02, Impeller (OpenGL)
- name: Linux_samsung_a02 new_gallery_impeller__transition_perf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up that we do not have any samsung a02 in the prod pool yet. What is the plan to add capacity in prod before enabling these tasks there? @yusuf-goog

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not enabling them in prod yet. Once zac is happy, i'll move some over to prod.

@zanderso zanderso merged commit 6a02483 into flutter:master Aug 17, 2023
@zanderso zanderso deleted the new-gallery-pixel-7 branch August 17, 2023 18:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants