-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Run new_gallery__transition_perf on Pixel 7 and Samsung A02 #132772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.ci.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this should be "cheetah"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be either (based on the values in the dimensions).
Pixel 7 Pro is more descriptive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm hoping to keep "Pixel 7 Pro"
yusuf-goog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one question
.ci.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this build be in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved this existing build from another place in the file to be next to all the other new_gallery__transition_perf benchmarks.
9fa1b71 to
0a6fd00
Compare
| task_name: new_gallery_impeller__transition_perf | ||
|
|
||
| # Samsung A02, Impeller (OpenGL) | ||
| - name: Linux_samsung_a02 new_gallery_impeller__transition_perf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up that we do not have any samsung a02 in the prod pool yet. What is the plan to add capacity in prod before enabling these tasks there? @yusuf-goog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not enabling them in prod yet. Once zac is happy, i'll move some over to prod.
No description provided.