Skip to content

Disable test order randomization on some leak tracker tests that are failing with today's seed #132766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 17, 2023
Merged

Disable test order randomization on some leak tracker tests that are failing with today's seed #132766

auto-submit merged 1 commit into from
Aug 17, 2023

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Aug 17, 2023

No description provided.

@jason-simmons jason-simmons requested a review from zanderso August 17, 2023 16:47
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 17, 2023
zanderso
zanderso approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with TODO and issue for follow-up

@goderbauer
Copy link
Member

goderbauer commented Aug 17, 2023

cc @polina-c

@polina-c polina-c mentioned this pull request Aug 17, 2023
Closed
@jason-simmons jason-simmons added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Aug 17, 2023
@auto-submit auto-submit bot merged commit 609382a into flutter:master Aug 17, 2023
@zanderso zanderso mentioned this pull request Aug 17, 2023
Merged
@loic-sharma loic-sharma mentioned this pull request Aug 17, 2023
Merged
8 tasks
@polina-c
Copy link
Contributor

polina-c commented Aug 17, 2023

fix: #132778

auto-submit bot pushed a commit that referenced this pull request Aug 17, 2023
@loic-sharma
[Windows] Allow overwriting the cache's Dart SDK archive license file… (
9e67e0e 
#132777)

Relands #132669 after it was reverted by #132773. The test failures were fixed separately by #132766

Tracking issue: #132592
Cherrypick issue: #132718
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
609382a Disable test order randomization on some leak tracker tests t…
0f6b5ce 
…hat are failing with today's seed (flutter/flutter#132766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
609382a Disable test order randomization on some leak tracker tests t…
152801b 
…hat are failing with today's seed (flutter/flutter#132766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
609382a Disable test order randomization on some leak tracker tests t…
cf24764 
…hat are failing with today's seed (flutter/flutter#132766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
609382a Disable test order randomization on some leak tracker tests t…
6c39481 
…hat are failing with today's seed (flutter/flutter#132766)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
609382a Disable test order randomization on some leak tracker tests t…
11a25d1 
…hat are failing with today's seed (flutter/flutter#132766)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
609382a Disable test order randomization on some leak tracker tests t…
a7d4852 
…hat are failing with today's seed (flutter/flutter#132766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jason-simmons @goderbauer @polina-c @zanderso