Skip to content

[CP] Fix lower bound of children from TwoDimensionalChildBuilderDelegate #132764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 3 commits into from
Aug 24, 2023
Merged

[CP] Fix lower bound of children from TwoDimensionalChildBuilderDelegate #132764

auto-submit merged 3 commits into from
Aug 24, 2023

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 17, 2023 •
edited
Loading

Found in flutter/packages#4536

The max x and max y index should allow for a case where there are no children in the viewport. This should be CP'd into stable once it lands.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks
Fix lower bound of children from TwoDimensionalChildBuilderDelegate (f…
f1fefa8 
…lutter#132713)

Found in flutter/packages#4536

The max x and max y index  should allow for a case where there are no children in the viewport.
This should be CP'd into stable once it lands.
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 17, 2023
Piinks
Piinks commented Aug 17, 2023
View reviewed changes
@Piinks Piinks mentioned this pull request Aug 17, 2023
Closed
@HansMuller HansMuller added the cp: approved Approved cherry-pick request label Aug 22, 2023
goderbauer
goderbauer approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023
@auto-submit auto-submit bot merged commit ff5b5b5 into flutter:flutter-3.13-candidate.0 Aug 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2023
@engine-flutter-autoroll
ff5b5b5fa [CP] Fix lower bound of children from TwoDimensionalChildBu…
3e3556e 
…ilderDelegate (flutter/flutter#132764)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2023
@engine-flutter-autoroll
ff5b5b5fa [CP] Fix lower bound of children from TwoDimensionalChildBu…
b7d77be 
…ilderDelegate (flutter/flutter#132764)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@HansMuller HansMuller Awaiting requested review from HansMuller

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: approved Approved cherry-pick request f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @goderbauer @HansMuller @itsjustkevin