Skip to content

Fix lower bound of children from TwoDimensionalChildBuilderDelegate #132713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Aug 17, 2023
Merged

Fix lower bound of children from TwoDimensionalChildBuilderDelegate #132713

auto-submit merged 2 commits into from
Aug 17, 2023

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 16, 2023

Found in flutter/packages#4536

The max x and max y index should allow for a case where there are no children in the viewport.
This should be CP'd into stable once it lands.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks requested a review from goderbauer August 16, 2023 23:42
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 16, 2023
goderbauer
goderbauer approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023
@auto-submit auto-submit bot merged commit ca31927 into flutter:master Aug 17, 2023
Piinks added a commit to Piinks/flutter that referenced this pull request Aug 17, 2023
@Piinks
Fix lower bound of children from TwoDimensionalChildBuilderDelegate (f…
f1fefa8 
…lutter#132713)

Found in flutter/packages#4536

The max x and max y index  should allow for a case where there are no children in the viewport.
This should be CP'd into stable once it lands.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ca31927 Fix lower bound of children from TwoDimensionalChildBuilderDe…
3e4e670 
…legate (flutter/flutter#132713)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
ca31927 Fix lower bound of children from TwoDimensionalChildBuilderDe…
b9a38d9 
…legate (flutter/flutter#132713)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
ca31927 Fix lower bound of children from TwoDimensionalChildBuilderDe…
230626e 
…legate (flutter/flutter#132713)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
ca31927 Fix lower bound of children from TwoDimensionalChildBuilderDe…
7414da8 
…legate (flutter/flutter#132713)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
ca31927 Fix lower bound of children from TwoDimensionalChildBuilderDe…
3316869 
…legate (flutter/flutter#132713)
@HansMuller HansMuller mentioned this pull request Aug 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
ca31927 Fix lower bound of children from TwoDimensionalChildBuilderDe…
2948ac8 
…legate (flutter/flutter#132713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Piinks @goderbauer