Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan keyonghan added the revert Autorevert PR (with "Reason for revert:" comment) label Aug 16, 2023
@auto-submit auto-submit bot merged commit 909400d into master Aug 16, 2023
@auto-submit auto-submit bot deleted the revert-132353-move_dartdoc_output branch August 16, 2023 02:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 16, 2023
flutter/flutter@f0e7c51...2502b51

2023-08-16 [email protected] Roll Flutter Engine from f186f1e9dc88 to 70b5700b79f6 (1 revision) (flutter/flutter#132655)
2023-08-16 [email protected] Roll Flutter Engine from e8670f03a9b1 to f186f1e9dc88 (2 revisions) (flutter/flutter#132649)
2023-08-16 [email protected] Fix flutter_tools use of --local-engine-host (flutter/flutter#132648)
2023-08-16 [email protected] Roll Flutter Engine from 7cc6a5832a0e to e8670f03a9b1 (3 revisions) (flutter/flutter#132623)
2023-08-16 [email protected] Roll Flutter Engine from decaccfc421d to 7cc6a5832a0e (1 revision) (flutter/flutter#132621)
2023-08-16 [email protected] Roll Flutter Engine from 659cdfc5a568 to decaccfc421d (6 revisions) (flutter/flutter#132618)
2023-08-16 [email protected] Roll Flutter Engine from 7409ce4ba0a8 to 659cdfc5a568 (1 revision) (flutter/flutter#132612)
2023-08-16 [email protected] Revert "Reorganize and clarify API doc generator" (flutter/flutter#132613)
2023-08-16 [email protected] Roll Flutter Engine from a9da7212eacf to 7409ce4ba0a8 (5 revisions) (flutter/flutter#132609)
2023-08-16 [email protected] Roll Flutter Engine from 22f03ffdc290 to a9da7212eacf (4 revisions) (flutter/flutter#132608)
2023-08-16 [email protected] [Reland] #131609 (flutter/flutter#132555)
2023-08-15 [email protected] Explain the keyboard manager protocol (flutter/flutter#132533)
2023-08-15 [email protected] Fix extent for null returning builder in GridView (flutter/flutter#132511)
2023-08-15 [email protected] Reorganize and clarify API doc generator (flutter/flutter#132353)
2023-08-15 [email protected] Fixing a memory leak in About box/dialog overlays (flutter/flutter#130842)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@gspencergoog
Copy link
Contributor

Thanks for reverting.

gspencergoog added a commit to gspencergoog/flutter that referenced this pull request Aug 17, 2023
auto-submit bot pushed a commit that referenced this pull request Aug 17, 2023
## Description

This re-lands #132353 with some additional options for keeping around the staging directory, so that the recipe for publishing docs can give those options and have the staging directory left around for deploying to the website.

Reverted in #132613

## Related Issues
 - https://flutter-review.googlesource.com/c/recipes/+/49580
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants