Add support for LOCAL_ENGINE_HOST to Linux/Mac/Win builds. #132579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
platform-ios
13 tasks
matanlurey
force-pushed
the
tool-local-engine-host-linwin
branch
from
676aa2b to
b195ac0
Compare
cbracken
reviewed
Aug 16, 2023
Co-authored-by: Christopher Fujino <[email protected]>
cbracken
reviewed
Aug 16, 2023
cbracken
reviewed
Aug 16, 2023
| if (localEngineInfo != null) { | ||
| final String engineOutPath = localEngineInfo.engineOutPath; | ||
| final String engineOutPath = localEngineInfo.targetOutPath; | ||
| // $ENGINE/src/out/foo_bar_baz -> $ENGINE/src |
Member
There was a problem hiding this comment.
Maybe for context:
Suggested change
| // $ENGINE/src/out/foo_bar_baz -> $ENGINE/src | |
| // Get the engine source root: $ENGINE/src/out/foo_bar_baz -> $ENGINE/src |
matanlurey
added
the
autosubmit
cbracken
reviewed
Aug 16, 2023
cbracken
reviewed
Aug 16, 2023
Co-authored-by: Chris Bracken <[email protected]>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards #132245.
I also couldn't help myself to do a very minor refactor and add some comments to
LocalEngineInfobecause I was getting confused myself implementing it.