Revert "Remove the fast reassemble / single widget reload feature" #132578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tool
This was referenced Aug 15, 2023
zanderso
approved these changes
Aug 15, 2023
zanderso
added
the
autosubmit
Contributor
|
I don't think this is the correct choice. If the benchmarks had it enabled, then the issue was that the benchmarks don't reflect reality. |
zanderso
removed
the
autosubmit
Member
|
I removed the autosubmit labels since it seems like benchmark that regressed shouldn't have been using the optimization in the first place? |
Contributor
Author
|
If we believe the numbers are just not reflecting reality then I'll close this revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #132255 for #132574 (hot reload perf regression).