Improvements to EditableText documentation #132532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: text input
justinmc
approved these changes
Aug 15, 2023
| /// rendering the floating cursor. | ||
| /// | ||
| /// The default is light grey. | ||
| /// Typically this would be set to [CupertinoColors.inactiveGray]. |
Contributor
There was a problem hiding this comment.
I was going to complain that this is only for Cupertino, but it looks like it's used for Material too...
Contributor
Author
There was a problem hiding this comment.
Yeah I had a bit of an adventure tracking all this down (hence all the documentation fixes about it, heh).
| /// [enableSuggestions], [paintCursorAboveText], [selectionHeightStyle], | ||
| /// [selectionWidthStyle], [textAlign], [dragStartBehavior], [scrollPadding], | ||
| /// [dragStartBehavior], [toolbarOptions], [rendererIgnoresPointer], | ||
| /// [readOnly], and [enableIMEPersonalizedLearning] arguments must not be null. |
Contributor
There was a problem hiding this comment.
Can we remove these kinds of comments now? Because everyone must be using null safety?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.