Allow latest pkg:material_color_utilities #132445

kevmoo · 2023-08-13T00:29:13Z

Allow latest pkg:material_color_utilities
Bump other dependencies to their latest - including pkg:web

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-08-13T00:29:15Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

guidezpl

flutter update-packages is needed, right?

christopherfujino · 2023-08-31T20:39:16Z

friendly ping @kevmoo

kevmoo · 2023-08-31T20:41:36Z

I'd LOVE someone to pick this up! I worry I'll waste more time w/ the reviewers that someone who knows how to hold everything right!

christopherfujino · 2023-08-31T21:27:54Z

I'd LOVE someone to pick this up! I worry I'll waste more time w/ the reviewers that someone who knows how to hold everything right!

sounds good, moving this to draft in the meantime to get it off our review queue.

flutter-dashboard · 2023-08-31T21:28:21Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

fixed!

christopherfujino

LGTM

packages/flutter_tools/lib/src/commands/update_packages.dart

auto-submit · 2023-10-11T22:18:09Z

auto label is removed for flutter/flutter/132445, due to This PR has not met approval requirements for merging. Changes were requested by {christopherfujino}, please make the needed changes and resubmit this PR.
You are a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

fixed!

christopherfujino

ship it again!

…2445)

Roll Flutter from 83134ac to 3865e49 (80 revisions) flutter/flutter@83134ac...3865e49 2023-10-13 [email protected] Roll Flutter Engine from e94f191d0ba4 to f9aed0267352 (2 revisions) (flutter/flutter#136537) 2023-10-13 [email protected] Roll Flutter Engine from 40ddc30b9d6c to e94f191d0ba4 (1 revision) (flutter/flutter#136532) 2023-10-13 [email protected] Roll Flutter Engine from 5acdac549034 to 40ddc30b9d6c (1 revision) (flutter/flutter#136526) 2023-10-13 [email protected] Roll Flutter Engine from b59d779d4f7f to 5acdac549034 (2 revisions) (flutter/flutter#136523) 2023-10-13 [email protected] Roll Flutter Engine from dc30b4cd0239 to b59d779d4f7f (2 revisions) (flutter/flutter#136521) 2023-10-13 [email protected] Roll Flutter Engine from 31ec5e31a914 to dc30b4cd0239 (1 revision) (flutter/flutter#136518) 2023-10-13 [email protected] Roll Flutter Engine from 7a6172e9d34c to 31ec5e31a914 (1 revision) (flutter/flutter#136516) 2023-10-13 [email protected] Roll Flutter Engine from ffb3b5b67f61 to 7a6172e9d34c (1 revision) (flutter/flutter#136515) 2023-10-13 [email protected] SearchAnchor should dispose created FocusNode and SearchController. (flutter/flutter#136120) 2023-10-13 [email protected] Roll Flutter Engine from dee90f16aacd to ffb3b5b67f61 (2 revisions) (flutter/flutter#136506) 2023-10-13 [email protected] Make constraints a covariant argument in RenderBox.computeDryLayout() (flutter/flutter#136432) 2023-10-12 [email protected] [web] remove loading indicator in -d web-server builds (flutter/flutter#136482) 2023-10-12 [email protected] Roll Flutter Engine from cb37ebc81939 to dee90f16aacd (3 revisions) (flutter/flutter#136502) 2023-10-12 [email protected] Roll Flutter Engine from 7eb20a09073e to cb37ebc81939 (2 revisions) (flutter/flutter#136492) 2023-10-12 [email protected] [SingleChildScrollView] Correct the offset pixels if it is out of range during layout (flutter/flutter#136239) 2023-10-12 [email protected] Allow `TapRegion` to consume tap events (flutter/flutter#136305) 2023-10-12 [email protected] Fix doc TODO (flutter/flutter#136485) 2023-10-12 [email protected] Roll Flutter Engine from f02006736390 to 7eb20a09073e (4 revisions) (flutter/flutter#136478) 2023-10-12 [email protected] Bump file,process,process_runner (flutter/flutter#136418) 2023-10-12 [email protected] Roll Flutter Engine from 664657d32992 to f02006736390 (3 revisions) (flutter/flutter#136467) 2023-10-12 [email protected] Fix PageView API doc sample fails on Desktop and Web (flutter/flutter#135910) 2023-10-12 [email protected] Add `--trace-to-file` option to `flutter run` (flutter/flutter#135713) 2023-10-12 [email protected] [flutter_tools] handle ERROR_INVALID_FUNCTION when trying to symlink across drives (flutter/flutter#136424) 2023-10-12 [email protected] Updates references to `finders.dart` in `controller.dart` to use a namespace. (flutter/flutter#136423) 2023-10-12 [email protected] Change some tests to run on macs without iOS devices attached (flutter/flutter#136463) 2023-10-12 [email protected] Roll Packages from 4b483f2 to 93c3f69 (9 revisions) (flutter/flutter#136461) 2023-10-12 [email protected] Fix typo in function name (flutter/flutter#136273) 2023-10-12 [email protected] Fix chip widgets don't the apply provided `iconTheme` (flutter/flutter#135751) 2023-10-12 [email protected] Roll Flutter Engine from 33a6d21b3364 to 664657d32992 (2 revisions) (flutter/flutter#136450) 2023-10-12 [email protected] Roll Flutter Engine from d00fabf0b919 to 33a6d21b3364 (5 revisions) (flutter/flutter#136442) 2023-10-12 [email protected] Roll Flutter Engine from 05e26c1b2c79 to d00fabf0b919 (5 revisions) (flutter/flutter#136431) 2023-10-12 [email protected] Floating `SnackBar` should always float above the bottom widgets (flutter/flutter#136411) 2023-10-12 [email protected] SearchBar should listen to changes to the SearchController and update suggestions on change (flutter/flutter#134337) 2023-10-11 [email protected] Allow latest pkg:material_color_utilities (flutter/flutter#132445) 2023-10-11 [email protected] Roll Flutter Engine from 8bf1460892c6 to 05e26c1b2c79 (3 revisions) (flutter/flutter#136422) 2023-10-11 [email protected] Create template for umbrella issues (flutter/flutter#134235) 2023-10-11 [email protected] [Windows Arm64] Add the 'platform_channel_sample_test_windows' Devicelab test (flutter/flutter#136401) 2023-10-11 [email protected] Roll Flutter Engine from 2b1b4b97f787 to 8bf1460892c6 (4 revisions) (flutter/flutter#136414) 2023-10-11 [email protected] Stop recommending android sdk root (flutter/flutter#136296) 2023-10-11 [email protected] Roll Flutter Engine from 5fcc16772cdd to 2b1b4b97f787 (1 revision) (flutter/flutter#136404) 2023-10-11 [email protected] Switch to Chrome for Testing instead of vanilla Chromium. (flutter/flutter#136214) 2023-10-11 [email protected] Reland "Switch flutter_tools to run frontend server from AOT snapshot" (flutter/flutter#136282) 2023-10-11 [email protected] Roll Flutter Engine from 4b02631b59bf to 5fcc16772cdd (2 revisions) (flutter/flutter#136397) 2023-10-11 [email protected] Fix some deprecation details (flutter/flutter#136385) 2023-10-11 [email protected] Roll Flutter Engine from ed67e8aa9aba to 4b02631b59bf (1 revision) (flutter/flutter#136392) 2023-10-11 [email protected] [leak-tracking] Add leak tracking in test/rendering - 1 (flutter/flutter#136275) ...

This cherry-picks *only* the package:web version changes from flutter#132445, and any changes needed to work with the new version.

This cherry-picks only the package:web version changes from flutter#132445, and any changes needed to work with the new version.

) This cherry-picks only the package:web version changes from #132445, and any changes needed to work with the new version. Helps enable #136405.

jperezr21 · 2023-12-20T18:31:09Z

Hi! This was merged on October, but the latest stable version which was released last week is still using meta 1.10.0. I'm getting the following error due to that:

Because every version of flutter_test from sdk depends on meta 1.10.0 and app depends on meta ^1.11.0, flutter_test from sdk is forbidden.
So, because app depends on flutter_test from sdk, version solving failed.

christopherfujino · 2023-12-20T18:47:26Z

Hi! This was merged on October, but the latest stable version which was released last week is still using meta 1.10.0. I'm getting the following error due to that:
Because every version of flutter_test from sdk depends on meta 1.10.0 and app depends on meta ^1.11.0, flutter_test from sdk is forbidden.
So, because app depends on flutter_test from sdk, version solving failed.

I would change your app constraint to be meta: ^1.10.0

jperezr21 · 2023-12-20T19:17:04Z

I'm actually trying to depend on analyzer 6.3.0, which depends on meta 1.11.0. This is the original error I was getting:

[WARNING] riverpod_generator on lib/contexts/auth/application/auth_controller.dart:
Your current `analyzer` version may not fully support your current SDK version.

Analyzer language version: 3.1.0
SDK language version: 3.2.0

Please update to the latest `analyzer` version (6.3.0) by running
`flutter packages upgrade`.

If you are not getting the latest version by running the above command, you
can try adding a constraint like the following to your pubspec to start
diagnosing why you can't get the latest version:

dev_dependencies:
  analyzer: ^6.3.0

kevmoo requested a review from guidezpl August 13, 2023 00:29

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 13, 2023

guidezpl previously requested changes Aug 14, 2023

View reviewed changes

christopherfujino marked this pull request as draft August 31, 2023 21:27

Allow latest pkg:material_color_utilities

03865c9

kevmoo force-pushed the kevmoo-patch-1 branch from 219d243 to 03865c9 Compare October 11, 2023 22:14

kevmoo marked this pull request as ready for review October 11, 2023 22:14

kevmoo requested a review from christopherfujino as a code owner October 11, 2023 22:14

kevmoo requested a review from guidezpl October 11, 2023 22:14

christopherfujino approved these changes Oct 11, 2023

View reviewed changes

kevmoo mentioned this pull request Oct 11, 2023

Coordinate a stable release of pkg:web (v0.3.0) with next stable release of Flutter #136405

Closed

4 tasks

kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2023

christopherfujino previously requested changes Oct 11, 2023

View reviewed changes

packages/flutter_tools/lib/src/commands/update_packages.dart Outdated Show resolved Hide resolved

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2023

Update update_packages.dart

a9bcf45

christopherfujino approved these changes Oct 11, 2023

View reviewed changes

auto-submit bot merged commit 3e60999 into master Oct 11, 2023

auto-submit bot deleted the kevmoo-patch-1 branch October 11, 2023 23:57

engine-flutter-autoroll mentioned this pull request Oct 12, 2023

Roll Flutter from 83134ac7e44c to f65dd3bac0c4 (53 revisions) flutter/packages#5128

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023

3e60999 Allow latest pkg:material_color_utilities (flutter/flutter#13…

6ace607

…2445)

engine-flutter-autoroll mentioned this pull request Oct 12, 2023

Roll Flutter from 83134ac7e44c to ddc9b40a98c1 (54 revisions) flutter/packages#5130

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023

3e60999 Allow latest pkg:material_color_utilities (flutter/flutter#13…

e255c46

…2445)

engine-flutter-autoroll mentioned this pull request Oct 12, 2023

Roll Flutter from 83134ac7e44c to ee7e41fec0de (55 revisions) flutter/packages#5131

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023

3e60999 Allow latest pkg:material_color_utilities (flutter/flutter#13…

8c71fc4

…2445)

engine-flutter-autoroll mentioned this pull request Oct 12, 2023

Roll Flutter from 83134ac7e44c to d6ec0cf564a1 (56 revisions) flutter/packages#5132

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023

3e60999 Allow latest pkg:material_color_utilities (flutter/flutter#13…

ed897f8

…2445)

engine-flutter-autoroll mentioned this pull request Oct 12, 2023

Roll Flutter from 83134ac7e44c to e8a0cf3ae884 (60 revisions) flutter/packages#5135

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023

3e60999 Allow latest pkg:material_color_utilities (flutter/flutter#13…

39c8284

…2445)

engine-flutter-autoroll mentioned this pull request Oct 12, 2023

Roll Flutter from 83134ac7e44c to 90b24fb5b1d5 (61 revisions) flutter/packages#5136

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023

3e60999 Allow latest pkg:material_color_utilities (flutter/flutter#13…

cc2714a

…2445)

engine-flutter-autoroll mentioned this pull request Oct 13, 2023

Roll Flutter from 83134ac7e44c to 3865e49a68ab (80 revisions) flutter/packages#5140

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023

3e60999 Allow latest pkg:material_color_utilities (flutter/flutter#13…

f61ea73

…2445)

guidezpl mentioned this pull request Oct 17, 2023

version solving failed material-foundation/flutter-packages#480

Closed

1 task

srujzs added a commit to srujzs/flutter that referenced this pull request Oct 23, 2023

Cherry-pick package:web update to version 0.3.0 from 0.2.1-beta

ede1ba0

This cherry-picks *only* the package:web version changes from flutter#132445, and any changes needed to work with the new version.

srujzs mentioned this pull request Oct 23, 2023

Cherry-pick package:web update to version 0.3.0 from 0.2.1-beta #137098

Closed

srujzs mentioned this pull request Oct 24, 2023

Cherry-pick package:web update to version 0.3.0 from 0.2.1-beta #137195

Merged

srujzs added a commit to srujzs/flutter that referenced this pull request Oct 24, 2023

Cherry-pick package:web update to version 0.3.0 from 0.2.1-beta

ff56649

This cherry-picks only the package:web version changes from flutter#132445, and any changes needed to work with the new version.

srujzs mentioned this pull request Oct 24, 2023

[CP] Cherry-pick package:web update to version 0.3.0 from 0.2.1-beta #137196

Closed

Allow latest pkg:material_color_utilities #132445

Allow latest pkg:material_color_utilities #132445

Uh oh!

Conversation

kevmoo commented Aug 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 13, 2023

Uh oh!

guidezpl left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Aug 31, 2023

Uh oh!

kevmoo commented Aug 31, 2023

Uh oh!

christopherfujino commented Aug 31, 2023

Uh oh!

flutter-dashboard bot commented Aug 31, 2023

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit bot commented Oct 11, 2023

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

jperezr21 commented Dec 20, 2023

Uh oh!

christopherfujino commented Dec 20, 2023

Uh oh!

jperezr21 commented Dec 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kevmoo commented Aug 13, 2023 •

edited

Loading