Skip to content

Disable Xcode Debug tests #132398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 11, 2023
Merged

Disable Xcode Debug tests #132398

auto-submit merged 1 commit into from
Aug 11, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Aug 11, 2023 •
edited
Loading

Temporarily removes Xcode debug tests.

Xcode tests are currently failing in CI for some infra-related issues. I have a fix for it (#132318) that I confirmed worked in presubmit, but I think the logic is better suited to live in recipes. However, it's going to be a bit of a learning curve to update recipes and might take me a couple days so disabling them in the meantime.

Tracking issue to readd when ready: #132309

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth mentioned this pull request Aug 10, 2023
Closed
christopherfujino
christopherfujino approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2023
@auto-submit auto-submit bot merged commit fff0824 into flutter:master Aug 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
8a8decd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
1203f50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
e94932e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
6b6dbcf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
efcd7e0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
a87eadf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
e0bcf83
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
e846db9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
efce650
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
069f5c1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
9512894
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
9d8cb08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
0d9a3ee
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
d9724de
vashworth added a commit to vashworth/flutter that referenced this pull request Aug 14, 2023
@vashworth
Revert "Disable Xcode Debug tests (flutter#132398)"
9646deb 
This reverts commit fff0824.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
1a1af10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
e22428d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
d6f43f7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
fa8a947
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
9a6754d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
917161b
@vashworth vashworth mentioned this pull request Aug 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
fff0824 Disable Xcode Debug tests (flutter/flutter#132398)
d4118cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vashworth @christopherfujino