Skip to content

Triple tap selection should not move beyond text boundary at the tapped location #132357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Aug 16, 2023
Merged

Triple tap selection should not move beyond text boundary at the tapped location #132357

auto-submit merged 1 commit into from
Aug 16, 2023

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Aug 11, 2023

This PR makes sure we do not select beyond the text boundary at the tapped position unless, we tap at the end of the text which in that case we should select the previous text boundary.

    // if x is a boundary defined by `textBoundary`, most textBoundaries (except
    // LineBreaker) guarantees `x == textBoundary.getLeadingTextBoundaryAt(x)`.
    // Use x - 1 here to make sure we don't get stuck at the fixed point x.
    final int start = textBoundary.getLeadingTextBoundaryAt(extent.offset - 1) ?? 0;

This was originally carried over from

flutter/packages/flutter/lib/src/widgets/editable_text.dart

Lines 4167 to 4179 in f468f33

// Returns the closest boundary location to `extent` but not including `extent`
// itself (unless already at the start/end of the text), in the direction
// specified by `forward`.
TextPosition _moveBeyondTextBoundary(TextPosition extent, bool forward, TextBoundary textBoundary) {
assert(extent.offset >= 0);
final int newOffset = forward
? textBoundary.getTrailingTextBoundaryAt(extent.offset) ?? _value.text.length
// if x is a boundary defined by `textBoundary`, most textBoundaries (except
// LineBreaker) guarantees `x == textBoundary.getLeadingTextBoundaryAt(x)`.
// Use x - 1 here to make sure we don't get stuck at the fixed point x.
: textBoundary.getLeadingTextBoundaryAt(extent.offset - 1) ?? 0;
return TextPosition(offset: newOffset);
}
which used this x - 1 to be able to move to the previous word boundary when navigating with a keyboard. When selecting by tapping/clicking we do not want to move past the text boundary at the tapped position so this adjustment is not needed.

Fixes #132126

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Aug 11, 2023
@Renzo-Olivares Renzo-Olivares changed the title Triple tap should not move beyond text boundary at the tapped location Triple tap selection should not move beyond text boundary at the tapped location Aug 11, 2023
justinmc
justinmc approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, LGTM 👍

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2023
@auto-submit auto-submit bot merged commit 0e15ab5 into flutter:master Aug 16, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0e15ab5 Triple tap selection should not move beyond text boundary at …
5afc4f3 
…the tapped location (flutter/flutter#132357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
0e15ab5 Triple tap selection should not move beyond text boundary at …
ff33322 
…the tapped location (flutter/flutter#132357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
0e15ab5 Triple tap selection should not move beyond text boundary at …
98da9c7 
…the tapped location (flutter/flutter#132357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
0e15ab5 Triple tap selection should not move beyond text boundary at …
06f65ab 
…the tapped location (flutter/flutter#132357)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 18, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023
@engine-flutter-autoroll
0e15ab5 Triple tap selection should not move beyond text boundary at …
d95b3b0 
…the tapped location (flutter/flutter#132357)
@HansMuller HansMuller mentioned this pull request Aug 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
0e15ab5 Triple tap selection should not move beyond text boundary at …
08d6e93 
…the tapped location (flutter/flutter#132357)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Triple tap on first TextField character also selects preceding paragraph

2 participants

@Renzo-Olivares @justinmc