Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Aug 11, 2023

Upstream issue: #132160
Upstream (DWDS) fix PR: dart-lang/webdev#2188

Beta 3.13 beta CP request: #132358

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository labels Aug 11, 2023
@christopherfujino christopherfujino changed the base branch from master to flutter-3.13-candidate.0 August 11, 2023 00:55
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino christopherfujino removed a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository labels Aug 11, 2023
@zanderso
Copy link
Member

Something is going wrong with the cirrus check on this PR.

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Aug 14, 2023

So I'm guessing that the release infra configs haven't been updated, which is why for ci.yaml validation I'm getting:

FormatException: ERROR: Mac_ios ios_app_with_extensions_test is a new builder added. it needs to be marked bringup: true
If ci.yaml wasn't changed, try git fetch upstream && git merge upstream/master

This target exists on the branch: https://github.com/flutter/flutter/blob/flutter-3.13-candidate.0/.ci.yaml#L3761

Meanwhile, I'm guessing upstream we bumped the cirrus token, which would need to be cherrypicked.

@github-actions github-actions bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 14, 2023
@zanderso
Copy link
Member

Meanwhile, I'm guessing upstream we bumped the cirrus token, which would need to be cherrypicked.

FYI @itsjustkevin

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2023
@auto-submit auto-submit bot merged commit 53841b2 into flutter:flutter-3.13-candidate.0 Aug 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants