Skip to content

Fix Xcode Debug integration tests #132318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vashworth wants to merge 11 commits into from
Closed

Fix Xcode Debug integration tests #132318

vashworth wants to merge 11 commits into from

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Aug 10, 2023 •
edited
Loading

Fixes Xcode debug integration tests by using an older version of Xcode that is compatible with the host OS.

Also, dismisses permission dialog and temporarily gives access to control Xcode.

FYI: I temporarily tested the tests in presubmit to make sure they pass:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac_ios%20integration_ui_ios_driver_xcode_debug/3/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Mac_ios%20flutter_gallery_ios__start_up_xcode_debug/5/overview

Fixes #132309.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 10, 2023
@vashworth vashworth changed the title [WIP] debugging integration test Fix Xcode Debug integration tests Aug 11, 2023
@vashworth vashworth closed this Aug 11, 2023
@vashworth vashworth mentioned this pull request Aug 11, 2023
Merged
8 tasks
fluttermirroringbot pushed a commit that referenced this pull request Aug 11, 2023
@vashworth
Disable Xcode Debug tests (#132398)
fff0824 
Temporarily removes Xcode debug tests. 

Xcode tests are currently failing in CI for some infra-related issues. I have a fix for it (#132318) that I confirmed worked in presubmit, but I think the logic is better suited to live in recipes. However, it's going to be a bit of a learning curve to update recipes and might take me a couple days so disabling them in the meantime.

Tracking issue to readd when ready: #132309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New Xcode Debug Integration Tests are Failing

1 participant

@vashworth