Skip to content

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Aug 9, 2023

Relands #130164 by reverting #132106.

It seems like there were legitimate Google test failures that I'll probably need to fix with a g3fix.

Fixes #130011

@justinmc justinmc self-assigned this Aug 9, 2023
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 9, 2023
@goderbauer
Copy link
Member

@LongCatIsLooong @Renzo-Olivares This came up during triage the other day. Do you happen to know if this is still something we plan to do?

@LongCatIsLooong
Copy link
Contributor

Not sure but the change makes sense to me. I can try relanding this.

@justinmc justinmc force-pushed the reland-can-request-focus-dropdown branch from 575ffaa to 7748d34 Compare February 5, 2024 18:24
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@justinmc
Copy link
Contributor Author

I'm closing this as I'm unable to fix the Google failures, unfortunately. I've created an issue to track this for the future. #149067

@justinmc justinmc closed this May 24, 2024
@justinmc justinmc deleted the reland-can-request-focus-dropdown branch May 24, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken selection on TextField if canRequestFocus: false

3 participants