-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Reland: Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus #132273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland: Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus #132273
Conversation
…Focus (flutter#130164) Simplifying the TextField API.
|
@LongCatIsLooong @Renzo-Olivares This came up during triage the other day. Do you happen to know if this is still something we plan to do? |
|
Not sure but the change makes sense to me. I can try relanding this. |
575ffaa to
7748d34
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I'm closing this as I'm unable to fix the Google failures, unfortunately. I've created an issue to track this for the future. #149067 |
Relands #130164 by reverting #132106.
It seems like there were legitimate Google test failures that I'll probably need to fix with a g3fix.
Fixes #130011