Reland root predictive back #132249
Reland root predictive back #132249
Conversation
github-actions
bot
added
a: text input
| /// [Android's predictive back](https://developer.android.com/guide/navigation/predictive-back-gesture) | ||
| /// feature will not animate when this boolean is false. | ||
| /// {@endtemplate} | ||
| final bool canPop; |
There was a problem hiding this comment.
With the old WillPopScope, the API was expecting a Future, which enabled hooking this into showing a dialog before popping the route. How would we support that here?
There was a problem hiding this comment.
I forgot to respond here because we discussed this on Discord, but for the record, I've added an example to the migration guide about this: flutter/website#9244. It's similar to the pop_scope.0.dart example in this PR.
There was a problem hiding this comment.
@justinmc it work in case pop to previous route. But can you please example how to hide the app when double-back at first route?
Before
Future<bool> onWillPop() {
DateTime now = DateTime.now();
if (_currentBackPressTime == null ||
now.difference(_currentBackPressTime!) > const Duration(seconds: 2)) {
_currentBackPressTime = now;
DialogUtil.showSnackBar(context, content: 'Press back again to exit');
return Future.value(false);
}
return Future.value(true);
}
I can not do it with new PopScope, the only way required setState to change canPop
Update: Fixed by using SystemNavigator.pop();
…s being called after the app is detached
justinmc
force-pushed
the
revert-132167-new_revert
branch
from
66374fb to
d7a302a
Compare
| onNotification: widget.onNavigationNotification == null ? null : (NavigationNotification notification) { | ||
| // By default, don't do anything with navigation notifications if | ||
| // there is no engine attached. | ||
| if (widget.onNavigationNotification == WidgetsApp.defaultOnNavigationNotification |
There was a problem hiding this comment.
This is weird can we work around this by making this non static? or a static method that takes in a widget state or changenotifier and returns a function ?
There was a problem hiding this comment.
It turns out I do need this fix. I've cleaned it up and made it non-static in this commit: b332896
justinmc
force-pushed
the
revert-132167-new_revert
branch
from
39c9b56 to
56c8777
Compare
justinmc
added
the
autosubmit
A user requested this example be added to the migration guide [on Discord](https://discord.com/channels/608014603317936148/969301283825659914/1140422179511603290). I think it's a reasonable request. Follow up on: #8952 Framework PR: flutter/flutter#132249 --------- Co-authored-by: Parker Lougheed <[email protected]>
| // Avoid dispatching a notification in the middle of a build. | ||
| switch (SchedulerBinding.instance.schedulerPhase) { | ||
| case SchedulerPhase.postFrameCallbacks: | ||
| notification.dispatch(subtreeContext); |
There was a problem hiding this comment.
Is it intentional that there's no break here? If so, can you add a comment that you're intentionally falling through?
There was a problem hiding this comment.
5 participants
Root predictive back (#120385) was reverted in #132167. This PR is an attempt to reland it.
The reversion happened due to failed Google tests (b/295073110).