Skip to content

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Aug 9, 2023

This is the last batch of web-only API migration.

Depends on flutter/engine#44516

Fixes #52899
Fixes #126831

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Aug 9, 2023
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2023
@auto-submit auto-submit bot merged commit 9a9c282 into flutter:master Aug 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 30, 2023
flutter/flutter@6c95737...1fe2495

2023-08-30 [email protected] Update SelectableRegion test for M3 (flutter/flutter#129627)
2023-08-30 [email protected] Remove cirrus tests from the flutter framework. (flutter/flutter#133575)
2023-08-30 [email protected] Roll Flutter Engine from 749e67a947bc to 69f04bdfe952 (2 revisions) (flutter/flutter#133621)
2023-08-30 [email protected] [flutter roll] Revert "Fix `Chip.shape`'s side is not used when provided in Material 3" (flutter/flutter#133615)
2023-08-30 [email protected] Roll Flutter Engine from 9f2cf5c99b0f to 749e67a947bc (2 revisions) (flutter/flutter#133618)
2023-08-30 [email protected] Roll Flutter Engine from c5854a6b3658 to 9f2cf5c99b0f (4 revisions) (flutter/flutter#133616)
2023-08-30 [email protected] No longer include `.packages` in created `.gitignore` files (flutter/flutter#133484)
2023-08-30 [email protected] Roll Flutter Engine from db3ecf8b2739 to c5854a6b3658 (1 revision) (flutter/flutter#133610)
2023-08-29 [email protected] Roll Flutter Engine from 1feb9302050c to db3ecf8b2739 (4 revisions) (flutter/flutter#133609)
2023-08-29 [email protected] Fix one notDisposed leak and mark another. (flutter/flutter#133595)
2023-08-29 [email protected] Roll Flutter Engine from 01a1579808b5 to 1feb9302050c (1 revision) (flutter/flutter#133604)
2023-08-29 [email protected] Upgrade packages. (flutter/flutter#133593)
2023-08-29 [email protected] Cover more tests with leak tracking. (flutter/flutter#133596)
2023-08-29 [email protected] Roll Flutter Engine from 73cc3fb451fd to 01a1579808b5 (3 revisions) (flutter/flutter#133591)
2023-08-29 [email protected] Added DropdownMenuEntry.labelWidget (flutter/flutter#133491)
2023-08-29 [email protected] Use a fake stopwatch to remove flakiness. (flutter/flutter#133229)
2023-08-29 [email protected] Roll Flutter Engine from d1e6eb080f08 to 73cc3fb451fd (3 revisions) (flutter/flutter#133580)
2023-08-29 [email protected] [web] Migrate remaining web-only API usages to `dart:ui_web` (flutter/flutter#132248)
2023-08-29 [email protected] Add doxygen doc generation. (flutter/flutter#131356)
2023-08-29 [email protected] Roll Flutter Engine from 50bd80773287 to d1e6eb080f08 (2 revisions) (flutter/flutter#133570)
2023-08-29 [email protected] ShortcutManager should dispatch creation in constructor. (flutter/flutter#133487)
2023-08-29 [email protected] Add FAB Additional Color Mappings example (flutter/flutter#133453)
2023-08-29 [email protected] Roll Flutter Engine from 65438c7bb46a to 50bd80773287 (1 revision) (flutter/flutter#133565)
2023-08-29 [email protected] Roll Packages from 383bffa to d7d3150 (13 revisions) (flutter/flutter#133564)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[web] Move all public web-only APIs to dart:ui_web Web-only pieces of dart:ui cause analysis errors

2 participants