Skip to content

Revert "Handle breaking changes in leak_tracker." #132223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Aug 9, 2023
Merged

Revert "Handle breaking changes in leak_tracker." #132223

zanderso merged 1 commit into from
Aug 9, 2023

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Aug 9, 2023

Reverts #131998

Reverting for #132222

@zanderso zanderso requested review from Piinks and polina-c August 9, 2023 14:18
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin labels Aug 9, 2023
Piinks
Piinks approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Aug 9, 2023
@zanderso
Copy link
Member Author

zanderso commented Aug 9, 2023

Landing revert without waiting for Google testing to get the tree reopened.

@zanderso zanderso merged commit f4c25bb into master Aug 9, 2023
@zanderso zanderso deleted the revert-131998-catch_ branch August 9, 2023 15:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2023
@engine-flutter-autoroll
f4c25bb Revert "Handle breaking changes in leak_tracker." (flutter/fl…
aa420d7 
…utter#132223)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 9, 2023
@engine-flutter-autoroll
Roll Flutter from 436df69 to f4c25bb (28 revisions) (#4666)
881c1f5 
flutter/flutter@436df69...f4c25bb

2023-08-09 [email protected] Revert "Handle breaking changes in leak_tracker." (flutter/flutter#132223)
2023-08-09 [email protected] Roll Flutter Engine from 8ec575168d44 to 3d3fb4faed02 (3 revisions) (flutter/flutter#132193)
2023-08-09 [email protected] Use pattern matching to avoid strange type annotations (flutter/flutter#131964)
2023-08-09 [email protected] Roll Flutter Engine from 6839b88283b6 to 8ec575168d44 (1 revision) (flutter/flutter#132182)
2023-08-09 [email protected] Roll Flutter Engine from 29b117aa4192 to 6839b88283b6 (1 revision) (flutter/flutter#132181)
2023-08-09 [email protected] Roll Flutter Engine from 82292b8390cb to 29b117aa4192 (5 revisions) (flutter/flutter#132179)
2023-08-09 [email protected] Add more info to `OverlayState.insert` error messages (flutter/flutter#129363)
2023-08-08 [email protected] Add `textCapitalization` property for `SearchBar` and `SearchAnchor` (flutter/flutter#131459)
2023-08-08 [email protected] Roll Flutter Engine from 934ebb005d02 to 82292b8390cb (3 revisions) (flutter/flutter#132166)
2023-08-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.2 to 2.21.3 (flutter/flutter#132165)
2023-08-08 [email protected] Revert of #120385 (flutter/flutter#132167)
2023-08-08 [email protected] Add `PopupMenuButton.iconColor`, `PopupMenuTheme.iconSize` and fix button icon using unexpected color propert (flutter/flutter#132054)
2023-08-08 [email protected] More PageStorage clarity in the documentation (flutter/flutter#131954)
2023-08-08 [email protected] Document that missed_frame_build_budget_count is misleading (flutter/flutter#132137)
2023-08-08 [email protected] Locate the template directory using a TemplatePathProvider. (flutter/flutter#132156)
2023-08-08 [email protected] Roll Flutter Engine from dd03fae51d38 to 934ebb005d02 (4 revisions) (flutter/flutter#132159)
2023-08-08 [email protected] Roll Flutter Engine from 22bd35a19352 to dd03fae51d38 (3 revisions) (flutter/flutter#132149)
2023-08-08 [email protected] Fix `TabBarTheme.indicatorColor` not applied in Material 2 (flutter/flutter#132123)
2023-08-08 [email protected] Paginated Data Table : Fixed Row number at footer in last page  (flutter/flutter#130389)
2023-08-08 [email protected] [web] Use benchmark callback from `dart:ui_web` (flutter/flutter#132087)
2023-08-08 [email protected] Roll Flutter Engine from 99fdac88f3c6 to 22bd35a19352 (3 revisions) (flutter/flutter#132141)
2023-08-08 [email protected] [framework] Add Search Web to selection controls for iOS (flutter/flutter#131898)
2023-08-08 [email protected] Remove Iterator from _History (flutter/flutter#132101)
2023-08-08 [email protected] Update dartdoc driver to match current behaviour (flutter/flutter#132078)
2023-08-08 [email protected] More documentation about warm-up frames (flutter/flutter#132085)
2023-08-08 [email protected] Roll Flutter Engine from 146c4c9487fc to 99fdac88f3c6 (3 revisions) (flutter/flutter#132135)
2023-08-08 [email protected] Roll Packages from d7ee75a to ac41376 (8 revisions) (flutter/flutter#132133)
2023-08-08 [email protected] Handle breaking changes in leak_tracker. (flutter/flutter#131998)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
f4c25bb Revert "Handle breaking changes in leak_tracker." (flutter/fl…
3474b46 
…utter#132223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

@polina-c polina-c Awaiting requested review from polina-c

Assignees

No one assigned

Labels

a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderso @Piinks