[bug] Fix null check crash by ReorderableList #132153

opxdelwin · 2023-08-08T19:27:47Z

Fix issue where if you drag the last element of ReorderableList and put it in the same index, a Null check error arises. This happens as index in _items is out of bounds (when reverse: true). Fix is to check if last element, dragged element and drop index is same, and return as nothing has changed. Find this video attached.

2023-08-08.16-09-52.mp4

Fixes issue #132077

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

Fixes issue flutter#132077

…o fix_132077

flutter-dashboard · 2023-08-08T19:27:50Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

goderbauer

Looks like this change is also missing a test. Can you please add one to ensure that we never break this again? Thanks.

packages/flutter/lib/src/widgets/reorderable_list.dart

goderbauer · 2023-08-08T22:15:14Z

Looks like some checks are also failing. Can you please take a look at those? Thanks!

Co-authored-by: Michael Goderbauer <[email protected]>

opxdelwin · 2023-08-09T11:31:39Z

Is something wrong with the tree? Many tests seem to be failing...

I have written necessary tests and made modifications. I'll probably wait till the tree is green, then commit changes.

Fixes issue flutter#132077

Co-authored-by: Michael Goderbauer <[email protected]>

…o fix_132077

opxdelwin · 2023-08-10T04:54:11Z

Ready to merge, do review. @goderbauer

packages/flutter/lib/src/widgets/reorderable_list.dart

…132077

This reverts commit cc59e8e.

opxdelwin · 2023-08-24T15:39:05Z

@Piinks @goderbauer do review latest changes

Piinks

LGTM! Thanks for your patience, I was out of town. :)

Piinks · 2023-09-12T00:53:16Z

@goderbauer can you provide a second review?

goderbauer · 2023-09-12T23:12:25Z

@opxdelwin Can you please rebase this PR to make the Google testing check happy?

goderbauer

LGTM

flutter/flutter@61b890b...58ba6c2 2023-09-14 [email protected] Roll Packages from 06cd9e9 to 275b76c (1 revision) (flutter/flutter#134734) 2023-09-14 [email protected] Update plugin_ffi generated file to match FFIgen 9.0.0 (flutter/flutter#134614) 2023-09-14 [email protected] LinkedText (Linkify) (flutter/flutter#125927) 2023-09-14 [email protected] _DayPicker should build days using separate stetefull widget _Day. (flutter/flutter#134607) 2023-09-13 [email protected] Remove `Path.combine` call from `CupertionoTextSelectionToolbar` (flutter/flutter#134369) 2023-09-13 [email protected] Update KeepAlive.debugTypicalAncestorWidgetClass (flutter/flutter#133498) 2023-09-13 [email protected] Fix null check crash by ReorderableList (flutter/flutter#132153) 2023-09-13 [email protected] Roll Flutter Engine from 154d6fd601a3 to cd90cc8469fb (3 revisions) (flutter/flutter#134691) 2023-09-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.5 to 2.21.6 (flutter/flutter#134692) 2023-09-13 [email protected] Roll Flutter Engine from b71b366e3de3 to 154d6fd601a3 (6 revisions) (flutter/flutter#134683) 2023-09-13 [email protected] [flutter_tools] Run ShutdownHooks when handling signals (flutter/flutter#134590) 2023-09-13 [email protected] Dispose routes in navigator when throwing exception (flutter/flutter#134596) 2023-09-13 [email protected] [framework] reduce ink sparkle uniform count. (flutter/flutter#133897) 2023-09-13 [email protected] Roll Flutter Engine from 5e671d5c90f9 to b71b366e3de3 (4 revisions) (flutter/flutter#134676) 2023-09-13 [email protected] Set the CONFIGURATION_BUILD_DIR in generated xcconfig when debugging core device (flutter/flutter#134493) 2023-09-13 [email protected] Bump gradle heap size limit in *everywhere* (flutter/flutter#134665) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

BirjuVachhani · 2023-10-05T12:18:11Z

Thanks @opxdelwin for fixing this! 🙌🏻

Fix issue where if you drag the last element of `ReorderableList` and put it in the same index, a `Null check` error arises. This happens as index in `_items` is out of bounds (when `reverse: true`). Fix is to check if last element, dragged element and drop index is same, and return as nothing has changed. Find this video attached. https://github.com/flutter/flutter/assets/84124091/8043cac3-eb08-42e1-87e7-8095ecab09dc Fixes issue flutter#132077

opxdelwin added 2 commits August 9, 2023 00:52

Fix null check crash by ReorderableList

3f36cb1

Fixes issue flutter#132077

Merge branch 'fix_132077' of https://github.com/opxdelwin/flutter int…

b931ae6

…o fix_132077

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 8, 2023

goderbauer reviewed Aug 8, 2023

View reviewed changes

packages/flutter/lib/src/widgets/reorderable_list.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/widgets/reorderable_list.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/widgets/reorderable_list.dart Outdated Show resolved Hide resolved

opxdelwin and others added 5 commits August 9, 2023 09:18

Format Documentation

d88a3e5

Co-authored-by: Michael Goderbauer <[email protected]>

Format control flow statements

747f870

Co-authored-by: Michael Goderbauer <[email protected]>

Relocate logic outside setState()

221aec3

Merge branch 'flutter:master' into fix_132077

b9fcf68

Merge branch 'flutter:master' into fix_132077

735d451

opxdelwin and others added 10 commits August 9, 2023 17:43

add regression test

6a876ad

Update reorderable_list.dart

f797734

Fix null check crash by ReorderableList

1dfb9f8

Fixes issue flutter#132077

Format Documentation

df485c1

Co-authored-by: Michael Goderbauer <[email protected]>

Format control flow statements

0b780f5

Co-authored-by: Michael Goderbauer <[email protected]>

Relocate logic outside setState()

e46a4e2

add regression test

6a52c54

Update reorderable_list.dart

f2dbfd4

Merge branch 'fix_132077' of https://github.com/opxdelwin/flutter int…

c1b27dd

…o fix_132077

remove whitespace

d8546c8

opxdelwin requested a review from goderbauer August 9, 2023 14:11

opxdelwin added 2 commits August 10, 2023 00:01

Merge branch 'flutter:master' into fix_132077

04ae847

Merge branch 'master' into fix_132077

c969d27

Merge branch 'master' into fix_132077

2185b4b

opxdelwin mentioned this pull request Aug 14, 2023

ReorderableList crash when reversed #132077

Closed

2 tasks

Piinks added the f: scrolling Viewports, list views, slivers, etc. label Aug 14, 2023

goderbauer requested a review from Piinks August 15, 2023 22:03

Piinks reviewed Aug 21, 2023

View reviewed changes

packages/flutter/lib/src/widgets/reorderable_list.dart Show resolved Hide resolved

opxdelwin added 2 commits August 23, 2023 01:37

Merge branch 'master' of https://github.com/flutter/flutter into fix_…

5d29fe5

…132077

Fix janky animation

949ac5b

opxdelwin requested a review from Piinks August 22, 2023 20:32

opxdelwin and others added 4 commits August 23, 2023 02:03

Re-run checks

b834fcc

run dart format

cc59e8e

Revert "run dart format"

15ff159

This reverts commit cc59e8e.

Merge branch 'master' into fix_132077

01ab903

Piinks approved these changes Sep 12, 2023

View reviewed changes

goderbauer approved these changes Sep 12, 2023

View reviewed changes

Merge branch 'master' into fix_132077

d8b6686

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2023

auto-submit bot merged commit b4953c3 into flutter:master Sep 13, 2023

engine-flutter-autoroll mentioned this pull request Sep 14, 2023

Roll Flutter from 61b890bfcbc1 to 58ba6c295d8c (16 revisions) flutter/packages#4928

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2023

b4953c3 Fix null check crash by ReorderableList (flutter/flutter#132153)

88adfd4

HansMuller mentioned this pull request Sep 15, 2023

Flutter Framework Team: Notable Commits #121415

Closed

opxdelwin changed the title ~~Fix null check crash by ReorderableList~~ [bug] Fix null check crash by ReorderableList Oct 1, 2023

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

b4953c3 Fix null check crash by ReorderableList (flutter/flutter#132153)

3d361ad

[bug] Fix null check crash by ReorderableList #132153

[bug] Fix null check crash by ReorderableList #132153

Uh oh!

Conversation

opxdelwin commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 8, 2023

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goderbauer commented Aug 8, 2023

Uh oh!

opxdelwin commented Aug 9, 2023

Uh oh!

opxdelwin commented Aug 10, 2023

Uh oh!

Uh oh!

opxdelwin commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Sep 12, 2023

Uh oh!

goderbauer commented Sep 12, 2023

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

BirjuVachhani commented Oct 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

opxdelwin commented Aug 8, 2023 •

edited

Loading

opxdelwin commented Aug 24, 2023 •

edited

Loading