Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Aug 7, 2023

Fixes #12296

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 7, 2023
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triggered*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks! fixed

@Hixie Hixie force-pushed the setState branch 2 times, most recently from 1af9241 to 9fe1556 Compare August 8, 2023 18:07
@goderbauer goderbauer requested a review from Piinks August 8, 2023 22:16
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit!

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ autosubmit Merge PR when tree becomes green via auto submit App labels Aug 10, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 10, 2023

auto label is removed for flutter/flutter/132090, due to - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Aug 10, 2023

These failures are flakes from a leak tracking change that was reverted. Rebasing.

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 10, 2023

auto label is removed for flutter/flutter/132090, Failed to merge flutter/flutter/132090 with Pull request flutter/flutter/132090 could not be merged: Required status check "ci.yaml validation" is expected..

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2023
@auto-submit auto-submit bot merged commit 1e35d3a into flutter:master Aug 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 11, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 11, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 11, 2023
flutter/flutter@685141b...9b6945b

2023-08-11 [email protected] Roll Flutter Engine from 93e8901490e7 to 77dfeea40e10 (1 revision) (flutter/flutter#132389)
2023-08-11 [email protected] Roll Flutter Engine from 4e532b957225 to 93e8901490e7 (1 revision) (flutter/flutter#132381)
2023-08-11 [email protected] Roll Flutter Engine from 25afdb9b696d to 4e532b957225 (4 revisions) (flutter/flutter#132376)
2023-08-11 [email protected] Roll Flutter Engine from da23fb0d9a1d to 25afdb9b696d (1 revision) (flutter/flutter#132370)
2023-08-11 [email protected] Roll Flutter Engine from acd1bc5536ef to da23fb0d9a1d (2 revisions) (flutter/flutter#132367)
2023-08-11 [email protected] Roll Flutter Engine from 578a8e8aabf6 to acd1bc5536ef (1 revision) (flutter/flutter#132365)
2023-08-11 [email protected] Roll Flutter Engine from 18a71c031f5f to 578a8e8aabf6 (1 revision) (flutter/flutter#132364)
2023-08-11 [email protected] Update `dev/devicelab/**` to provide `--local-engine-host`. (flutter/flutter#132342)
2023-08-10 [email protected] Roll Flutter Engine from b019ac62f21f to 18a71c031f5f (2 revisions) (flutter/flutter#132347)
2023-08-10 [email protected] Roll Flutter Engine from 16b01b98af20 to b019ac62f21f (1 revision) (flutter/flutter#132341)
2023-08-10 [email protected] Update `flutter_tools/bin/*.(dart|sh)` to provide, if set, --local-engine-host. (flutter/flutter#132336)
2023-08-10 [email protected] Update application id and bundle id of a11y assessment app (flutter/flutter#132334)
2023-08-10 [email protected] Roll Flutter Engine from a9be77e6f475 to 16b01b98af20 (6 revisions) (flutter/flutter#132332)
2023-08-10 [email protected] Remove the fast reassemble / single widget reload feature (flutter/flutter#132255)
2023-08-10 [email protected] Analyze code snippets in integration_test docs (flutter/flutter#132314)
2023-08-10 [email protected] Adds SemanticsNode Finders for searching the semantics tree (flutter/flutter#127137)
2023-08-10 [email protected] TextField should correctly resolve provided style for material states (flutter/flutter#132330)
2023-08-10 [email protected] setState documentation (flutter/flutter#132090)
2023-08-10 [email protected] Roll Flutter Engine from ea7730c16301 to a9be77e6f475 (6 revisions) (flutter/flutter#132328)
2023-08-10 [email protected] Fix: use --web-launch-url and --web-hostname arguments in flutter drive (flutter/flutter#131763)
2023-08-10 [email protected] GridView sample code (flutter/flutter#131900)
2023-08-10 [email protected] Upgrade flutter packages. (flutter/flutter#132326)
2023-08-10 [email protected] TextPainter migration cleanup (flutter/flutter#132317)
2023-08-10 [email protected] An example of parentData usage. (flutter/flutter#131818)
2023-08-10 [email protected] Add hasInteractedByUser getter in FormField (flutter/flutter#131539)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a "design discussion" section to the setState method

3 participants