Skip to content

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Aug 4, 2023

fixes #131931

Every time I search for the time picker in the API docs I end up in the TimePickerDialog docs.

We should link showTimePicker so it can be easier to reach it and mention it can be used directly to show a dialog with a time picker.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…the time picker in the `TimePickerDialog` docs
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 4, 2023
@TahaTesser TahaTesser changed the title Mention showTimePicker function be can be used to show dialog with … Mention showTimePicker function be can be used to show dialog with the time picker in the TimePickerDialog docs Aug 4, 2023
@TahaTesser TahaTesser requested a review from HansMuller August 4, 2023 15:00
@TahaTesser TahaTesser added the d: api docs Issues with https://api.flutter.dev/ label Aug 4, 2023
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2023
@auto-submit auto-submit bot merged commit 05f9a96 into flutter:master Aug 4, 2023
@TahaTesser TahaTesser deleted the update_time_picker_dialog_docs branch August 4, 2023 17:38
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 5, 2023
…og with the time picker in the `TimePickerDialog` docs (flutter/flutter#131932)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 5, 2023
…og with the time picker in the `TimePickerDialog` docs (flutter/flutter#131932)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2023
…og with the time picker in the `TimePickerDialog` docs (flutter/flutter#131932)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2023
…og with the time picker in the `TimePickerDialog` docs (flutter/flutter#131932)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2023
…og with the time picker in the `TimePickerDialog` docs (flutter/flutter#131932)
tarrinneal pushed a commit to flutter/packages that referenced this pull request Aug 7, 2023
flutter/flutter@2ba9f7b...ad0aa8d

2023-08-07 [email protected] Roll Flutter Engine from
b10891e0d8d8 to 5b47c0577060 (1 revision) (flutter/flutter#132040)
2023-08-07 [email protected] Roll Flutter Engine from
4304d6180264 to b10891e0d8d8 (1 revision) (flutter/flutter#132037)
2023-08-07 [email protected] Roll Flutter Engine from
eb91441398a1 to 4304d6180264 (1 revision) (flutter/flutter#132031)
2023-08-07 [email protected] Constrain
_RenderScaledInlineWidget child size in computeDryLayout
(flutter/flutter#131765)
2023-08-07 [email protected] Roll Flutter Engine from
15b5707af406 to eb91441398a1 (1 revision) (flutter/flutter#132025)
2023-08-07 [email protected] Roll Flutter Engine from
a1d513f78bbb to 15b5707af406 (2 revisions) (flutter/flutter#132020)
2023-08-06 [email protected] Roll Flutter Engine from
c9bd380ccbb0 to a1d513f78bbb (1 revision) (flutter/flutter#132015)
2023-08-06 [email protected] Roll Flutter Engine from
060c95f94364 to c9bd380ccbb0 (1 revision) (flutter/flutter#132008)
2023-08-06 [email protected] Roll Flutter Engine from
af7aaae2f1f9 to 060c95f94364 (1 revision) (flutter/flutter#132006)
2023-08-06 [email protected] Roll Flutter Engine from
cdafc05a7217 to af7aaae2f1f9 (2 revisions) (flutter/flutter#132004)
2023-08-05 [email protected] Roll Flutter Engine from
b512df490c94 to cdafc05a7217 (1 revision) (flutter/flutter#131996)
2023-08-05 [email protected] Take paint offset
into account for inline children hit test in Editable
(flutter/flutter#131675)
2023-08-05 [email protected] Roll Flutter Engine from
d26b8c8fb60c to b512df490c94 (1 revision) (flutter/flutter#131987)
2023-08-05 [email protected] Roll Flutter Engine from
2ce2913acbe4 to d26b8c8fb60c (1 revision) (flutter/flutter#131986)
2023-08-05 [email protected] Roll Flutter Engine from
628b086265f2 to 2ce2913acbe4 (1 revision) (flutter/flutter#131983)
2023-08-05 [email protected] Roll Flutter Engine from
7302a678e58e to 628b086265f2 (1 revision) (flutter/flutter#131976)
2023-08-05 [email protected] Roll Flutter Engine from
138a1ea9a692 to 7302a678e58e (2 revisions) (flutter/flutter#131975)
2023-08-05 [email protected] Roll Flutter Engine from
a0d650e37f5d to 138a1ea9a692 (2 revisions) (flutter/flutter#131972)
2023-08-05 [email protected] Add TODO to refactor error handling.
(flutter/flutter#131878)
2023-08-05 [email protected] Manual roll Flutter Engine
from 4f4734cd48da to a0d650e37f5d (3 revisions) (flutter/flutter#131967)
2023-08-05 [email protected] Mark the
ci_yaml roller task so that it is not backfilled.
(flutter/flutter#131966)
2023-08-05 [email protected] mark linux packages_autoroller
flaky because of token issue (flutter/flutter#131970)
2023-08-04 [email protected] Sped up the time
to find macrobenchmarks. (flutter/flutter#131959)
2023-08-04 [email protected] Roll Flutter Engine from
c254deb8fbda to 4f4734cd48da (2 revisions) (flutter/flutter#131955)
2023-08-04 [email protected] Roll Flutter Engine from
a7bea8621f4b to c254deb8fbda (3 revisions) (flutter/flutter#131950)
2023-08-04 [email protected] Predictive back support for root
routes (flutter/flutter#120385)
2023-08-04 [email protected] Roll Flutter Engine from
e9f80bff0703 to a7bea8621f4b (3 revisions) (flutter/flutter#131948)
2023-08-04 [email protected] Roll Flutter Engine from
badca1f7f8c9 to e9f80bff0703 (6 revisions) (flutter/flutter#131943)
2023-08-04 [email protected] Mention `showTimePicker` function be can
be used to show dialog with the time picker in the `TimePickerDialog`
docs (flutter/flutter#131932)
2023-08-04 [email protected] Check for
simulator runtime in flutter doctor (flutter/flutter#131795)
2023-08-04 [email protected] Roll Packages from
d00c1f9 to ce53da1 (3 revisions) (flutter/flutter#131935)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
…og with the time picker in the `TimePickerDialog` docs (flutter/flutter#131932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mention showTimePicker in the TimePickerDialog docs

2 participants