-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Update default menu text styles for Material 3 #131930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default menu text styles for Material 3 #131930
Conversation
b08a0c1 to
592a6b7
Compare
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@gspencergoog As the one that noticed it and raised the issue, I'm sure it will, it will probably not only break Google golden tests, but also a lot of expectation of default styles in apps that use them. Thus some kind of warning/info before this eventually hits stable is probably prudent. Still, better to get it according to spec now, than a lot later. If somebody must have the old style it is an easy adjustment, so I don't think it should be big issue for anybody, as long as they get clear information. |
|
Thanks for sharing @TahaTesser! I've asked @HansMuller to take a look because he will better be able to give this the go ahead. You are right about using flutter-announce and such to follow the breaking change policy. |
592a6b7 to
c3ef410
Compare
|
Resolved conflict from #132104 |
|
Caught up with @HansMuller today on this. This should be good to go but first let's ensure we have clear migration to the old styes set up. @TahaTesser can you make a migration guide for flutter/website? Thank you! |
Will do. Thanks for the update. |
3a28ebf to
fea2ffd
Compare
|
After rebasing to conflicts, a50776e is causing rounding errors. |
9243fe6 to
25c4cd0
Compare
|
@gspencergoog |
|
@Piinks |
25c4cd0 to
58ed8db
Compare
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/flutter@54c98d7...bd836cc 2023-08-23 [email protected] Roll Packages from c730a90 to 3060b1a (4 revisions) (flutter/flutter#133149) 2023-08-23 [email protected] Roll Flutter Engine from 7d56840865d2 to 72a06427bd37 (8 revisions) (flutter/flutter#133139) 2023-08-23 [email protected] Manual roll Flutter Engine from b190f9015049 to 7d56840865d2 (15 revisions) (flutter/flutter#133106) 2023-08-23 [email protected] Reference AppLifecycleListener from widgets library (flutter/flutter#132995) 2023-08-23 [email protected] Support disabling animations in the CLI (flutter/flutter#132239) 2023-08-23 [email protected] Don't run on Samsung S10, shift to Pixel 7 Pro (flutter/flutter#133085) 2023-08-23 [email protected] Add test to mark recording as leaking. (flutter/flutter#133073) 2023-08-22 [email protected] Revert "[gallery] roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda" (flutter/flutter#133095) 2023-08-22 [email protected] [gallery] roll gallery to ecfb9e5352bd12032301b12b30d5853d83d89bda (flutter/flutter#133083) 2023-08-22 [email protected] Update default menu text styles for Material 3 (flutter/flutter#131930) 2023-08-22 [email protected] Roll Flutter Engine from 28b8bd5d5d91 to b190f9015049 (3 revisions) (flutter/flutter#133078) 2023-08-22 [email protected] Fix `FlexibleSpaceBar.title` doesn't respect the leading widget (flutter/flutter#132573) 2023-08-22 [email protected] Roll Flutter Engine from 21437d384b56 to 28b8bd5d5d91 (1 revision) (flutter/flutter#133075) 2023-08-22 [email protected] Roll Flutter Engine from 090754879679 to 21437d384b56 (1 revision) (flutter/flutter#133072) 2023-08-22 [email protected] Add support for `Future<List<int>?>` to `MatchesGoldenFile` (flutter/flutter#132965) 2023-08-22 [email protected] Roll Packages from e26f3b9 to c730a90 (3 revisions) (flutter/flutter#133067) 2023-08-22 [email protected] Roll Flutter Engine from ff375bf5d8eb to 090754879679 (1 revision) (flutter/flutter#133066) 2023-08-22 [email protected] Increase heap size for examples/flutter_view gradle build (flutter/flutter#133064) 2023-08-22 [email protected] Roll Flutter Engine from c5e0152b01f4 to ff375bf5d8eb (4 revisions) (flutter/flutter#133062) 2023-08-22 [email protected] Fix memory leak in Form (flutter/flutter#132987) 2023-08-22 [email protected] Re-enable Xcode Debug tests (flutter/flutter#132523) 2023-08-22 [email protected] Increase heap for gradle in examples/platform_view (flutter/flutter#133052) 2023-08-22 [email protected] Cover more tests with leak tracking. (flutter/flutter#132806) 2023-08-22 [email protected] Roll Flutter Engine from f5f099a4a5e3 to c5e0152b01f4 (4 revisions) (flutter/flutter#133049) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Breaking change migration for flutter/flutter#131930 --------- Co-authored-by: Parker Lougheed <[email protected]>
…9236) Breaking change migration for flutter/flutter#131930 --------- Co-authored-by: Parker Lougheed <[email protected]>

Related #131676
Description
Fix default input text style for
DropdownMenuFix default text style for
MenuAnchor's menu items (whichDropdownMenuuses for menu items)Default
DropdownMenuInput text styleDefault
DropdownMenumenu item text styleDefault
MenuAnchormenu item text styleCode sample
expand to view the code sample
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.