Skip to content

Update xcode project template to 9.1 #13193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xster merged 1 commit into from
Nov 28, 2017
Merged

Update xcode project template to 9.1 #13193

xster merged 1 commit into from
Nov 28, 2017

Conversation

@xster
Copy link
Member

@xster xster commented Nov 23, 2017

No description provided.

@xster xster requested review from cbracken and mit-mit November 23, 2017 23:12
@mit-mit
Copy link
Member

mit-mit commented Nov 24, 2017

Verified that this causes xCode 9.1 to open cleanly without any warnings, yay!

@mit-mit
Copy link
Member

mit-mit commented Nov 24, 2017

Two remaining issues I see:

  1. An icon warning: "/Users/mit/tmp/xp1/ios/Runner/Assets.xcassets: A 1024x1024 app store icon is required for iOS apps"
  2. After running: "2017-11-24 09:22:08.376694+0100 Runner[7523:10781563] You've implemented -[ application:didReceiveRemoteNotification:fetchCompletionHandler:], but you still need to add "remote-notification" to the list of your supported UIBackgroundModes in your Info.plist."

Should we handle those as separate issues?

@cbracken
Copy link
Member

cbracken commented Nov 28, 2017 •
edited
Loading

I'm fine with us following up with those two issues as followups. Thanks for doing this cleanup.

@xster can you file an issue for (1) so we don't lose track of it? Looks like there's already related issue #9984 for (2).

@cbracken
Copy link
Member

cbracken commented Nov 28, 2017

lgtm

@xster
Copy link
Member Author

xster commented Nov 28, 2017

#13237

@xster xster merged commit 7ad69b3 into flutter:master Nov 28, 2017
@xster xster deleted the xcode_91_template branch November 28, 2017 23:49
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@xster
Update xcode project template to 9.1 (flutter#13193)
806656d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 18, 2019
@engine-flutter-autoroll
6c2381d Revert "Custom compositor layers must take into account the d…
e0a4c2f 
…evice pixel ratio. (flutter#13193)" (flutter/engine#13211)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 18, 2019
Merged
engine-flutter-autoroll added a commit that referenced this pull request Oct 18, 2019
@engine-flutter-autoroll
Roll engine 508146f..7a621a7 (26 commits) (#43017)
7da9561 
[email protected]:flutter/engine.git/compare/508146f0defb...7a621a7

git log 508146f..7a621a7 --no-merges --oneline
2019-10-18 [email protected] Roll src/third_party/skia 20eafffd2d2f..b80d31f8cbe2 (4 commits) (flutter/engine#13226)
2019-10-18 [email protected] Roll src/third_party/skia da29d70f1a59..20eafffd2d2f (1 commits) (flutter/engine#13223)
2019-10-18 [email protected] Roll src/third_party/skia 63a387395751..da29d70f1a59 (11 commits) (flutter/engine#13221)
2019-10-18 [email protected] Roll fuchsia/sdk/core/linux-amd64 from WpvU_... to _G94w... (flutter/engine#13220)
2019-10-18 [email protected] Specify a human readable reason for an error from the embedder API. (flutter/engine#13218)
2019-10-18 [email protected] Roll fuchsia/sdk/core/mac-amd64 from _9Uy_... to KNygX... (flutter/engine#13219)
2019-10-17 [email protected] Reland ICU update to 64.2 (flutter/engine#13216)
2019-10-17 [email protected] Use `window.devicePixelRatio` in the CanvasKit backend (flutter/engine#13192)
2019-10-17 [email protected] Re-enable WeakPtr ThreadChecker and fix associated failures (flutter/engine#12257)
2019-10-17 [email protected] Re-land "Custom compositor layers must take into account the device pixel ratio."
2019-10-17 [email protected] Add trace events around custom compositor callbacks. (flutter/engine#13212)
2019-10-17 [email protected] Roll src/third_party/skia 93e853bf2b83..63a387395751 (9 commits) (flutter/engine#13208)
2019-10-17 [email protected] Roll src/third_party/dart 9b3c7f64d8..a61c775db8 (5 commits)
2019-10-17 [email protected] Document //flutter/runtime/dart_snapshot.h (flutter/engine#13196)
2019-10-17 [email protected] Revert "Custom compositor layers must take into account the device pixel ratio. (#13193)" (flutter/engine#13211)
2019-10-17 [email protected] wrap the text in text editing. This was causing a missalingment issue in textarea. (flutter/engine#13207)
2019-10-17 [email protected] Custom compositor layers must take into account the device pixel ratio. (flutter/engine#13193)
2019-10-17 [email protected] [web] Environment variable to disable felt snapshot (flutter/engine#13187)
2019-10-17 [email protected] Roll src/third_party/dart 9e636b5ab4..9b3c7f64d8 (5 commits)
2019-10-17 [email protected] Roll src/third_party/skia 0df7697235b4..93e853bf2b83 (1 commits) (flutter/engine#13205)
2019-10-17 [email protected] Roll fuchsia/sdk/core/linux-amd64 from ek5iQ... to WpvU_... (flutter/engine#13203)
2019-10-17 [email protected] Roll fuchsia/sdk/core/mac-amd64 from 6j3Gw... to _9Uy_... (flutter/engine#13202)
2019-10-17 [email protected] Roll src/third_party/skia 6a19e03047cc..0df7697235b4 (1 commits) (flutter/engine#13200)
2019-10-17 [email protected] Roll src/third_party/dart 1e3e9ee04c..9e636b5ab4 (9 commits)
2019-10-17 [email protected] Roll src/third_party/skia f29cb70281d5..6a19e03047cc (5 commits) (flutter/engine#13198)
2019-10-17 [email protected] Roll src/third_party/dart f020ce5d23..1e3e9ee04c (12 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@engine-flutter-autoroll @Inconnu08
Roll engine 508146f..7a621a7 (26 commits) (flutter#43017)
7bc1dbb 
[email protected]:flutter/engine.git/compare/508146f0defb...7a621a7

git log 508146f..7a621a7 --no-merges --oneline
2019-10-18 [email protected] Roll src/third_party/skia 20eafffd2d2f..b80d31f8cbe2 (4 commits) (flutter/engine#13226)
2019-10-18 [email protected] Roll src/third_party/skia da29d70f1a59..20eafffd2d2f (1 commits) (flutter/engine#13223)
2019-10-18 [email protected] Roll src/third_party/skia 63a387395751..da29d70f1a59 (11 commits) (flutter/engine#13221)
2019-10-18 [email protected] Roll fuchsia/sdk/core/linux-amd64 from WpvU_... to _G94w... (flutter/engine#13220)
2019-10-18 [email protected] Specify a human readable reason for an error from the embedder API. (flutter/engine#13218)
2019-10-18 [email protected] Roll fuchsia/sdk/core/mac-amd64 from _9Uy_... to KNygX... (flutter/engine#13219)
2019-10-17 [email protected] Reland ICU update to 64.2 (flutter/engine#13216)
2019-10-17 [email protected] Use `window.devicePixelRatio` in the CanvasKit backend (flutter/engine#13192)
2019-10-17 [email protected] Re-enable WeakPtr ThreadChecker and fix associated failures (flutter/engine#12257)
2019-10-17 [email protected] Re-land "Custom compositor layers must take into account the device pixel ratio."
2019-10-17 [email protected] Add trace events around custom compositor callbacks. (flutter/engine#13212)
2019-10-17 [email protected] Roll src/third_party/skia 93e853bf2b83..63a387395751 (9 commits) (flutter/engine#13208)
2019-10-17 [email protected] Roll src/third_party/dart 9b3c7f64d8..a61c775db8 (5 commits)
2019-10-17 [email protected] Document //flutter/runtime/dart_snapshot.h (flutter/engine#13196)
2019-10-17 [email protected] Revert "Custom compositor layers must take into account the device pixel ratio. (flutter#13193)" (flutter/engine#13211)
2019-10-17 [email protected] wrap the text in text editing. This was causing a missalingment issue in textarea. (flutter/engine#13207)
2019-10-17 [email protected] Custom compositor layers must take into account the device pixel ratio. (flutter/engine#13193)
2019-10-17 [email protected] [web] Environment variable to disable felt snapshot (flutter/engine#13187)
2019-10-17 [email protected] Roll src/third_party/dart 9e636b5ab4..9b3c7f64d8 (5 commits)
2019-10-17 [email protected] Roll src/third_party/skia 0df7697235b4..93e853bf2b83 (1 commits) (flutter/engine#13205)
2019-10-17 [email protected] Roll fuchsia/sdk/core/linux-amd64 from ek5iQ... to WpvU_... (flutter/engine#13203)
2019-10-17 [email protected] Roll fuchsia/sdk/core/mac-amd64 from 6j3Gw... to _9Uy_... (flutter/engine#13202)
2019-10-17 [email protected] Roll src/third_party/skia 6a19e03047cc..0df7697235b4 (1 commits) (flutter/engine#13200)
2019-10-17 [email protected] Roll src/third_party/dart 1e3e9ee04c..9e636b5ab4 (9 commits)
2019-10-17 [email protected] Roll src/third_party/skia f29cb70281d5..6a19e03047cc (5 commits) (flutter/engine#13198)
2019-10-17 [email protected] Roll src/third_party/dart f020ce5d23..1e3e9ee04c (12 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cbracken cbracken cbracken approved these changes

@mit-mit mit-mit Awaiting requested review from mit-mit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xster @mit-mit @cbracken @googlebot