Updates app link gradle tasks and remove vm services #131805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
chunhtai
force-pushed
the
android-deeplinks-remove
branch
from
71a6bdf to
fea6c29
Compare
christopherfujino
approved these changes
Aug 2, 2023
Contributor
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
This LGTM, though I would appreciate a quick sanity check from @reidbaker
reidbaker
reviewed
Aug 4, 2023
Contributor
There was a problem hiding this comment.
Can you make these constants that are referenced from here and in flutter.groovy?
packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/android_gradle_print_app_link_domains_test.dart
Outdated
Show resolved
Hide resolved
chunhtai
force-pushed
the
android-deeplinks-remove
branch
from
8d7618c to
5a2e24f
Compare
chunhtai
commented
Aug 4, 2023
Contributor
Author
There was a problem hiding this comment.
Hi @reidbaker May I have some advice on how to better import other file? This works when running ./gradlew from android subproject directly, but does not work when running flutter build apk.
Contributor
Author
There was a problem hiding this comment.
reverted the change
chunhtai
force-pushed
the
android-deeplinks-remove
branch
2 times, most recently
from
8bd131f to
4f4e142
Compare
chunhtai
force-pushed
the
android-deeplinks-remove
branch
from
084f490 to
01a1a05
Compare
reidbaker
approved these changes
Aug 11, 2023
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 19, 2023
flutter/flutter@5a556f8...6f227c0 2023-08-19 [email protected] Space character should be optional when tree shaking fonts (flutter/flutter#132880) 2023-08-19 [email protected] Roll Flutter Engine from 654d3a2c8494 to f4bffdcf8536 (5 revisions) (flutter/flutter#132876) 2023-08-18 [email protected] SelectionArea on iOS should toggle the context menu when tapping on the previous selection (flutter/flutter#132851) 2023-08-18 [email protected] Forward port API docs creation realm handling from prior script (flutter/flutter#132867) 2023-08-18 [email protected] Roll Flutter Engine from 72c4e61fdbfa to 654d3a2c8494 (3 revisions) (flutter/flutter#132868) 2023-08-18 [email protected] Roll Flutter Engine from 83fdadaf12f0 to 72c4e61fdbfa (2 revisions) (flutter/flutter#132861) 2023-08-18 [email protected] Updates app link gradle tasks and remove vm services (flutter/flutter#131805) 2023-08-18 [email protected] Roll Flutter Engine from 58f7d8ee3e2c to 83fdadaf12f0 (7 revisions) (flutter/flutter#132857) 2023-08-18 [email protected] doc: add flag params (flutter/flutter#132485) 2023-08-18 [email protected] Add a new MatrixTransition and refactor ScaleTransition and RotationT� (flutter/flutter#131084) 2023-08-18 [email protected] fixes l10n for CupertinoDatePicker in monthYear mode (flutter/flutter#130934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deeplink validation tool will be a static app in devtool instead of regular app. A Static app doesn't require a running app; therefore, we can't call these API through vmservices. I decided to convert these API into flutter analyzer command, which will be done in a separate PR #131009.
The reason these print tasks are converted into file dumps is to reduce the amount of data encoding and decoding. Instead of passing data through stdout, the devtool can read the files generated by gradle tasks instead.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.