[framework] Add Look Up to selection controls for iOS #131798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add missing Cupertino localizations attempt to fix remote tests fix failing test fix linux-analyze rename var, remove unintentionally commited changes rename var PR feedback fix linux analyze move platform channel check for look up into test from set up fix tests restart tests
github-actions
bot
added
a: text input
hellohuanlin
approved these changes
Aug 2, 2023
Contributor
|
carrying over the stamp from another PR. can you link that PR in your description? |
Contributor
Author
|
@hellohuanlin I did! "This is the same PR as #130532, this is an attempt to fix the Google Testing issue" |
Contributor
|
oops - i missed that. |
LouiseHsu
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 3, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 3, 2023
flutter/flutter@b3f99ff...c00d241 2023-08-03 [email protected] Manual roll Flutter Engine from 9304c0074d29 to 4c1157b9da54 (24 revisions) (flutter/flutter#131830) 2023-08-03 [email protected] Assert against infinite values of control points in CatmullRomSpline (flutter/flutter#131820) 2023-08-02 [email protected] Update stack_frame.dart to parse unexpected error format to null. (flutter/flutter#131786) 2023-08-02 [email protected] Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus (flutter/flutter#130164) 2023-08-02 [email protected] Mention that the widget tree is not disposed on exit (flutter/flutter#131637) 2023-08-02 [email protected] [framework] Add Look Up to selection controls for iOS (flutter/flutter#131798) 2023-08-02 [email protected] Add documentation in flutter.groovy noting that we always use the latest available android version (flutter/flutter#131705) 2023-08-02 [email protected] [framework] lerp images in a save layer. (flutter/flutter#131703) 2023-08-02 [email protected] Roll Packages from 3dc00c1 to 4e4961a (1 revision) (flutter/flutter#131788) 2023-08-02 [email protected] add gem dependency to the ios_app_with_extensions_test (flutter/flutter#131713) 2023-08-02 [email protected] Roll Flutter Engine from d6b962d0e36d to 9304c0074d29 (4 revisions) (flutter/flutter#131790) 2023-08-02 [email protected] [flutter_tools] set terminal.singleCharMode to false after attach finishes (flutter/flutter#131723) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
@LouiseHsu Thanks for the commit! will this support "Lookup" option for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds framework support for the Look Up feature in iOS.
Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-07-11.at.15.23.56.mp4
The corresponding merged engine PR can be found here.
This PR addresses #82907
More details are available in this design doc.
This is the same PR as #130532, this is an attempt to fix the Google Testing issue
Pre-launch Checklist
///).