Skip to content

Conversation

@vashworth
Copy link
Contributor

Redo of #130728 - code is the same as before. That PR was stuck in Google testing and then I messed up the rebase so started over.


Starting in Xcode 15, the simulator is no longer included in Xcode and must be downloaded and installed separately. This adds a validation to flutter doctor to warn when the needed simulator runtime is missing.

Validation message looks like:

[!] Xcode - develop for iOS and macOS (Xcode 15.0)
    ! iOS 17.0 Simulator not installed; this may be necessary for iOS and macOS development.
      To download and install the platform, open Xcode, select Xcode > Settings > Platforms,
      and click the GET button for the required platform.

      For more information, please visit:
        https://developer.apple.com/documentation/xcode/installing-additional-simulator-runtimes

It may also show an error like this when something goes wrong when checking for the simulator:

[!] Xcode - develop for iOS and macOS (Xcode 15.0)
    ✗ Unable to find the iPhone Simulator SDK.

Note: I'm unsure of in the future if the SDK and the simulator runtime will need to match the exact version or just the major. For now, it only checks against the major version.

Part 3 of #129558.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Aug 2, 2023
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2023
@auto-submit auto-submit bot merged commit b39604e into flutter:master Aug 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 7, 2023
tarrinneal pushed a commit to flutter/packages that referenced this pull request Aug 7, 2023
flutter/flutter@2ba9f7b...ad0aa8d

2023-08-07 [email protected] Roll Flutter Engine from
b10891e0d8d8 to 5b47c0577060 (1 revision) (flutter/flutter#132040)
2023-08-07 [email protected] Roll Flutter Engine from
4304d6180264 to b10891e0d8d8 (1 revision) (flutter/flutter#132037)
2023-08-07 [email protected] Roll Flutter Engine from
eb91441398a1 to 4304d6180264 (1 revision) (flutter/flutter#132031)
2023-08-07 [email protected] Constrain
_RenderScaledInlineWidget child size in computeDryLayout
(flutter/flutter#131765)
2023-08-07 [email protected] Roll Flutter Engine from
15b5707af406 to eb91441398a1 (1 revision) (flutter/flutter#132025)
2023-08-07 [email protected] Roll Flutter Engine from
a1d513f78bbb to 15b5707af406 (2 revisions) (flutter/flutter#132020)
2023-08-06 [email protected] Roll Flutter Engine from
c9bd380ccbb0 to a1d513f78bbb (1 revision) (flutter/flutter#132015)
2023-08-06 [email protected] Roll Flutter Engine from
060c95f94364 to c9bd380ccbb0 (1 revision) (flutter/flutter#132008)
2023-08-06 [email protected] Roll Flutter Engine from
af7aaae2f1f9 to 060c95f94364 (1 revision) (flutter/flutter#132006)
2023-08-06 [email protected] Roll Flutter Engine from
cdafc05a7217 to af7aaae2f1f9 (2 revisions) (flutter/flutter#132004)
2023-08-05 [email protected] Roll Flutter Engine from
b512df490c94 to cdafc05a7217 (1 revision) (flutter/flutter#131996)
2023-08-05 [email protected] Take paint offset
into account for inline children hit test in Editable
(flutter/flutter#131675)
2023-08-05 [email protected] Roll Flutter Engine from
d26b8c8fb60c to b512df490c94 (1 revision) (flutter/flutter#131987)
2023-08-05 [email protected] Roll Flutter Engine from
2ce2913acbe4 to d26b8c8fb60c (1 revision) (flutter/flutter#131986)
2023-08-05 [email protected] Roll Flutter Engine from
628b086265f2 to 2ce2913acbe4 (1 revision) (flutter/flutter#131983)
2023-08-05 [email protected] Roll Flutter Engine from
7302a678e58e to 628b086265f2 (1 revision) (flutter/flutter#131976)
2023-08-05 [email protected] Roll Flutter Engine from
138a1ea9a692 to 7302a678e58e (2 revisions) (flutter/flutter#131975)
2023-08-05 [email protected] Roll Flutter Engine from
a0d650e37f5d to 138a1ea9a692 (2 revisions) (flutter/flutter#131972)
2023-08-05 [email protected] Add TODO to refactor error handling.
(flutter/flutter#131878)
2023-08-05 [email protected] Manual roll Flutter Engine
from 4f4734cd48da to a0d650e37f5d (3 revisions) (flutter/flutter#131967)
2023-08-05 [email protected] Mark the
ci_yaml roller task so that it is not backfilled.
(flutter/flutter#131966)
2023-08-05 [email protected] mark linux packages_autoroller
flaky because of token issue (flutter/flutter#131970)
2023-08-04 [email protected] Sped up the time
to find macrobenchmarks. (flutter/flutter#131959)
2023-08-04 [email protected] Roll Flutter Engine from
c254deb8fbda to 4f4734cd48da (2 revisions) (flutter/flutter#131955)
2023-08-04 [email protected] Roll Flutter Engine from
a7bea8621f4b to c254deb8fbda (3 revisions) (flutter/flutter#131950)
2023-08-04 [email protected] Predictive back support for root
routes (flutter/flutter#120385)
2023-08-04 [email protected] Roll Flutter Engine from
e9f80bff0703 to a7bea8621f4b (3 revisions) (flutter/flutter#131948)
2023-08-04 [email protected] Roll Flutter Engine from
badca1f7f8c9 to e9f80bff0703 (6 revisions) (flutter/flutter#131943)
2023-08-04 [email protected] Mention `showTimePicker` function be can
be used to show dialog with the time picker in the `TimePickerDialog`
docs (flutter/flutter#131932)
2023-08-04 [email protected] Check for
simulator runtime in flutter doctor (flutter/flutter#131795)
2023-08-04 [email protected] Roll Packages from
d00c1f9 to ce53da1 (3 revisions) (flutter/flutter#131935)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth added a commit to vashworth/flutter that referenced this pull request Aug 9, 2023
Redo of flutter#130728 - code is the same as before. That PR was stuck in Google testing and then I messed up the rebase so started over.

----

Starting in Xcode 15, the simulator is no longer included in Xcode and must be downloaded and installed separately. This adds a validation to `flutter doctor` to warn when the needed simulator runtime is missing.

Validation message looks like:
```
[!] Xcode - develop for iOS and macOS (Xcode 15.0)
    ! iOS 17.0 Simulator not installed; this may be necessary for iOS and macOS development.
      To download and install the platform, open Xcode, select Xcode > Settings > Platforms,
      and click the GET button for the required platform.

      For more information, please visit:
        https://developer.apple.com/documentation/xcode/installing-additional-simulator-runtimes
```

It may also show an error like this when something goes wrong when checking for the simulator:
```
[!] Xcode - develop for iOS and macOS (Xcode 15.0)
    � Unable to find the iPhone Simulator SDK.
```

Note: I'm unsure of in the future if the SDK and the simulator runtime will need to match the exact version or just the major. For now, it only checks against the major version.

Part 3 of flutter#129558.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants