Fix reentrancy with WidgetBindingObserver callbacks #131774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
Contributor
|
Looks like this might cause some observers to not be called (at least |
Contributor
Author
|
Looking into that. |
Contributor
Author
|
Needed to flush the asynchronous callbacks before removing - otherwise the new observer was sticking around after the |
gspencergoog
approved these changes
Aug 2, 2023
| WidgetsBinding.instance.handleRequestAppExit(); | ||
| expect(observer.removeSelf(), greaterThan(11)); | ||
| await tester.idle(); | ||
| expect(observer.removeSelf(), greaterThan(1)); |
Contributor
There was a problem hiding this comment.
Did you mean to change this from 11 to 1?
Contributor
Author
There was a problem hiding this comment.
I don't want to use an exact value cause this goes up or down pretty quickly depending on how many methods get called. I think it's probably ok to just make sure it got added more than in the constructor, so I put it to 1.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 2, 2023
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
Part of flutter#131678 Fixes up callsites for WidgetsBindingObserver related callbacks.
camsim99
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 2, 2023
Roll Flutter from 1d59196 to b3f99ff (32 revisions) flutter/flutter@1d59196...b3f99ff 2023-08-02 [email protected] Fix reentrancy with WidgetBindingObserver callbacks (flutter/flutter#131774) 2023-08-02 [email protected] Update .ci.yaml to add new shard to prevent timeouts (flutter/flutter#131712) 2023-08-02 [email protected] Fix flex methods for min and max column widths (flutter/flutter#131724) 2023-08-02 [email protected] Manual roll Flutter Engine from 9dae7b708bda to d6b962d0e36d (25 revisions) (flutter/flutter#131785) 2023-08-02 [email protected] Added standard deviation to rasterizer results. (flutter/flutter#131781) 2023-08-02 [email protected] Tiny remove outdated comments (flutter/flutter#130387) 2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump ubuntu from `f8f6584` to `c9820a4` in /dev/ci/docker_linux (flutter/flutter#130292) 2023-08-02 [email protected] Fix for endless recursion for getLayoutExplorerNode on a Tooltip (flutter/flutter#131486) 2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump google/mirror-branch-action from 1.0 to 2.0 (flutter/flutter#126600) 2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump dessant/lock-threads from 4.0.0 to 4.0.1 (flutter/flutter#128741) 2023-08-02 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.3 to 3.1.4 (flutter/flutter#126885) 2023-08-02 [email protected] Update `ThemeData`'s factory method documents (flutter/flutter#123984) 2023-08-02 [email protected] Fix Scrollable `TabBar` for Material 3 (flutter/flutter#131409) 2023-08-02 [email protected] ImageProvider.toString uses double.toStringAsFixed (flutter/flutter#131348) 2023-08-02 [email protected] Roll Flutter Engine from 10a1f9cb74c9 to 9dae7b708bda (4 revisions) (flutter/flutter#131706) 2023-08-01 [email protected] Upgrade Flutter libraries. (flutter/flutter#131700) 2023-08-01 [email protected] Roll Flutter Engine from 1aadc75dd5a7 to 10a1f9cb74c9 (1 revision) (flutter/flutter#131696) 2023-08-01 [email protected] Roll Flutter Engine from e3f817ce9953 to 1aadc75dd5a7 (2 revisions) (flutter/flutter#131691) 2023-08-01 [email protected] Roll Packages from 60e9a54 to 3dc00c1 (5 revisions) (flutter/flutter#131692) 2023-08-01 [email protected] Avoid concurrent modification of persistent frame callbacks (flutter/flutter#131677) 2023-08-01 [email protected] Roll Flutter Engine from ae535c024146 to e3f817ce9953 (1 revision) (flutter/flutter#131687) 2023-08-01 [email protected] Roll Flutter Engine from 703d45539059 to ae535c024146 (4 revisions) (flutter/flutter#131679) 2023-08-01 [email protected] Roll Flutter Engine from f1c80ce98499 to 703d45539059 (1 revision) (flutter/flutter#131668) 2023-08-01 [email protected] Roll Flutter Engine from 2583c07f6a69 to f1c80ce98499 (1 revision) (flutter/flutter#131663) 2023-08-01 [email protected] Roll Flutter Engine from 25b9d1088d09 to 2583c07f6a69 (1 revision) (flutter/flutter#131661) 2023-08-01 [email protected] Roll Flutter Engine from 7651b3cba6ba to 25b9d1088d09 (4 revisions) (flutter/flutter#131655) 2023-08-01 [email protected] Roll Flutter Engine from 1433e23c8a3d to 7651b3cba6ba (2 revisions) (flutter/flutter#131648) 2023-08-01 [email protected] Roll Flutter Engine from 791f505c8c6e to 1433e23c8a3d (1 revision) (flutter/flutter#131647) 2023-08-01 [email protected] Roll Flutter Engine from bb2a903c934c to 791f505c8c6e (4 revisions) (flutter/flutter#131645) 2023-08-01 [email protected] 🐛 Treat empty ARB content as empty map when decoding (flutter/flutter#131242) 2023-08-01 [email protected] Roll Flutter Engine from fe2369565f59 to bb2a903c934c (3 revisions) (flutter/flutter#131639) 2023-07-31 [email protected] Roll Flutter Engine from b83172a4e995 to fe2369565f59 (12 revisions) (flutter/flutter#131638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #131678
Fixes up callsites for WidgetsBindingObserver related callbacks.